From: Junio C Hamano <gitster@pobox•com>
To: Sebastian Schuberth <sschuberth@gmail•com>
Cc: Karsten Blees <karsten.blees@gmail•com>,
Git List <git@vger•kernel.org>, Johannes Sixt <j6t@kdbg•org>
Subject: Re: [PATCH 0/3] Fix MSVC compile errors and cleanup stat definitions
Date: Wed, 11 Sep 2013 11:11:44 -0700 [thread overview]
Message-ID: <xmqqd2oftehr.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAHGBnuOFYS-9+h0H3VD5X-EbZKX9nENaZfAZbLUm9zwDtr-3SA@mail.gmail.com> (Sebastian Schuberth's message of "Wed, 11 Sep 2013 18:16:05 +0200")
Sebastian Schuberth <sschuberth@gmail•com> writes:
> On Wed, Sep 11, 2013 at 6:09 PM, Junio C Hamano <gitster@pobox•com> wrote:
>
>> Karsten Blees <karsten.blees@gmail•com> writes:
>>
>>> A few minor fixes for the MSVC build.
>>>
>>> Also here: https://github.com/kblees/git/tree/kb/fix-msvc-stat-definitions
>>>
>>> Karsten Blees (3):
>>> MSVC: fix compile errors due to missing libintl.h
>>> MSVC: fix compile errors due to macro redefinitions
>>> MSVC: fix stat definition hell
>>>
>>> compat/mingw.h | 21 +++++++++++++++++----
>>> compat/msvc.h | 15 ---------------
>>> config.mak.uname | 1 +
>>> 3 files changed, 18 insertions(+), 19 deletions(-)
>>
>> I won't be a good person to review, suggest improvements on, and/or
>> judge these patches. I'm Cc'ing regulars who work on mingw port for
>> their help and Ack.
>
> Acked-by: Sebastian Schuberth <sschuberth@gmail•com>
Thanks; will queue these three and your follow-up on top.
prev parent reply other threads:[~2013-09-11 18:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 23:20 [PATCH 0/3] Fix MSVC compile errors and cleanup stat definitions Karsten Blees
2013-09-10 23:21 ` [PATCH 1/3] MSVC: fix compile errors due to missing libintl.h Karsten Blees
2013-09-10 23:22 ` [PATCH 2/3] MSVC: fix compile errors due to macro redefinitions Karsten Blees
2013-09-10 23:23 ` [PATCH 3/3] MSVC: fix stat definition hell Karsten Blees
2013-09-11 0:35 ` Eric Sunshine
2013-09-11 16:02 ` Sebastian Schuberth
2013-09-11 16:09 ` [PATCH 0/3] Fix MSVC compile errors and cleanup stat definitions Junio C Hamano
2013-09-11 16:16 ` Sebastian Schuberth
2013-09-11 18:11 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd2oftehr.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=j6t@kdbg$(echo .)org \
--cc=karsten.blees@gmail$(echo .)com \
--cc=sschuberth@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox