Subject: Re: [PATCH 3/4] t/lib-git-p4: silence output when killing p4d and its watchdog

From: Junio C Hamano <[email-masked]>
Date: Tue, 02 Jun 2026 18:32:55 +0900

Patrick Steinhardt <[email-masked]> writes:

>  stop_p4d_and_watchdog () {
>  	kill -9 $p4d_pid $watchdog_pid
> +	wait $p4d $watchdog_pid 2>/dev/null
>  }

Shoudln't we be waiting on $p4d_pid (not $p4d)...

> @@ -175,7 +176,7 @@ retry_until_success () {
>  
>  stop_and_cleanup_p4d () {
>  	kill -9 $p4d_pid $watchdog_pid
> -	wait $p4d_pid
> +	wait $p4d_pid $watchdog_pid 2>/dev/null
>  	rm -rf "$db" "$cli" "$pidfile"
>  }

... like we do here?