public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Jacob Keller <jacob.e.keller@intel•com>
Cc: git@vger•kernel.org,  Jacob Keller <jacob.keller@gmail•com>,
	 Patrick Steinhardt <ps@pks•im>
Subject: Re: [PATCH 4/6] submodule--helper: improve logic for fallback remote name
Date: Tue, 17 Jun 2025 06:30:56 -0700	[thread overview]
Message-ID: <xmqqecvixzov.fsf@gitster.g> (raw)
In-Reply-To: <20250610-jk-submodule-helper-use-url-v1-4-6d14c1504e91@gmail.com> (Jacob Keller's message of "Tue, 10 Jun 2025 17:52:18 -0700")

Jacob Keller <jacob.e.keller@intel•com> writes:

> diff --git a/remote.h b/remote.h
> index 7e4943ae3a70ecefa3332d211084762ca30b59b6..ef0de4aa64e9ccd32cc2eea076c00386dcba1161 100644
> --- a/remote.h
> +++ b/remote.h
> @@ -338,6 +338,8 @@ const char *remote_for_branch(struct branch *branch, int *explicit);
>  const char *pushremote_for_branch(struct branch *branch, int *explicit);
>  char *remote_ref_for_branch(struct branch *branch, int for_push);
>  
> +const char *repo_default_remote(struct repository *repo);
> +

This breaks "make hdr-check" because nobody up to this point
mentions "struct repository".

It seems doing an opaque forward declaration is in vogue at least in
this file?

 remote.h | 1 +
 1 file changed, 1 insertion(+)

diff --git c/remote.h w/remote.h
index ef0de4aa64..86020ae2d3 100644
--- c/remote.h
+++ w/remote.h
@@ -9,6 +9,7 @@
 
 struct option;
 struct transport_ls_refs_options;
+struct repository;
 
 /**
  * The API gives access to the configuration related to remotes. It handles

  parent reply	other threads:[~2025-06-17 13:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11  0:52 [PATCH 0/6] submodule: improve remote lookup logic Jacob Keller
2025-06-11  0:52 ` [PATCH 1/6] dir: move starts_with_dot(_dot)_slash to dir.h Jacob Keller
2025-06-11  0:52 ` [PATCH 2/6] remote: remove the_repository from some functions Jacob Keller
2025-06-11  0:52 ` [PATCH 3/6] remote: check branch->merge before access in branch_release Jacob Keller
2025-06-11  0:52 ` [PATCH 4/6] submodule--helper: improve logic for fallback remote name Jacob Keller
2025-06-17  2:58   ` Lidong Yan
2025-06-17 17:53     ` Jacob Keller
2025-06-17 18:57     ` Jacob Keller
2025-06-17 13:30   ` Junio C Hamano [this message]
2025-06-11  0:52 ` [PATCH 5/6] submodule: move get_default_remote_submodule() Jacob Keller
2025-06-11  0:52 ` [PATCH 6/6] submodule: look up remotes by URL first Jacob Keller
2025-06-16 22:27 ` [PATCH 0/6] submodule: improve remote lookup logic Jacob Keller
2025-06-16 22:41   ` Junio C Hamano
2025-06-16 23:20     ` Jacob Keller
2025-06-17 15:09       ` Junio C Hamano
2025-06-17 16:16         ` Junio C Hamano
2025-06-17 21:28         ` Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqecvixzov.fsf@gitster.g \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=jacob.e.keller@intel$(echo .)com \
    --cc=jacob.keller@gmail$(echo .)com \
    --cc=ps@pks$(echo .)im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox