public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Derrick Stolee <derrickstolee@github•com>
Cc: Victoria Dye <vdye@github•com>,
	Shuqi Liang <cheskaqiqi@gmail•com>,
	git@vger•kernel.org
Subject: Re: [RFC PATCH 1/1] check-attr: integrate with sparse-index
Date: Mon, 27 Feb 2023 10:51:12 -0800	[thread overview]
Message-ID: <xmqqedqbt00v.fsf@gitster.g> (raw)
In-Reply-To: <cd7b9a2f-4f52-9da8-19c3-2c5cda7b8160@github.com> (Derrick Stolee's message of "Mon, 27 Feb 2023 12:57:32 -0500")

Derrick Stolee <derrickstolee@github•com> writes:

> Victoria is right that it is helpful to first establish test coverage of
> the builtin for correctness reasons before making this change. It helps to
> add tests for cases that would require expanding the sparse index, such as
> checking the attributes for paths outside of the sparse-checkout cone.
>
> Once the correctness tests are in place, you can then make this change to
> the builtin and add the tests that check ensure_not_expanded, since the
> change at that point is _only_ that we are allowing the builtin to
> operate upon the sparse index without expanding it immediately after read.
>
> A good example of this "final step" is [1], which updates the builtin for
> 'git diff' as well as adding _only_ the ensure_not_expanded tests.

Thanks for a detailed help.

next prev parent reply	other threads:[~2023-02-27 18:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27  5:05 [RFC PATCH 0/1] check-attr: integrate with sparse-index Shuqi Liang
2023-02-27  5:05 ` [RFC PATCH 1/1] " Shuqi Liang
2023-02-27 17:18   ` Victoria Dye
2023-02-27 17:57     ` Derrick Stolee
2023-02-27 18:51       ` Junio C Hamano [this message]
2023-02-28 18:10       ` Shuqi Liang
2023-02-27 17:18 ` [RFC PATCH 0/1] " Victoria Dye

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqedqbt00v.fsf@gitster.g \
    --to=gitster@pobox$(echo .)com \
    --cc=cheskaqiqi@gmail$(echo .)com \
    --cc=derrickstolee@github$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=vdye@github$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox