From: Junio C Hamano <gitster@pobox•com>
To: "Moritz Baumann via GitGitGadget" <gitgitgadget@gmail•com>
Cc: git@vger•kernel.org, Luke Diamand <luke@diamand•org>,
Moritz Baumann <moritz.baumann@sap•com>
Subject: Re: [PATCH 1/2] git-p4: fix typo in P4Submit.applyCommit()
Date: Wed, 20 Jul 2022 09:09:43 -0700 [thread overview]
Message-ID: <xmqqedyf4vg8.fsf@gitster.g> (raw)
In-Reply-To: <1484eee8961227a9901e3baa052c74a6d992c220.1658298900.git.gitgitgadget@gmail.com> (Moritz Baumann via GitGitGadget's message of "Wed, 20 Jul 2022 06:34:58 +0000")
"Moritz Baumann via GitGitGadget" <gitgitgadget@gmail•com> writes:
> From: Moritz Baumann <moritz.baumann@sap•com>
>
> Signed-off-by: Moritz Baumann <moritz.baumann@sap•com>
> ---
> git-p4.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-p4.py b/git-p4.py
> index 8fbf6eb1fe3..1de3d6f1cd4 100755
> --- a/git-p4.py
> +++ b/git-p4.py
> @@ -2226,7 +2226,7 @@ class P4Submit(Command, P4UserMap):
> raw=True):
> if regexp.search(line):
> if verbose:
> - print("got keyword match on %s in %s in %s" % (regex.pattern, line, file))
> + print("got keyword match on %s in %s in %s" % (regexp.pattern, line, file))
OK. That's an obvious fix.
> kwfiles[file] = regexp
> break
next prev parent reply other threads:[~2022-07-20 16:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 6:34 [PATCH 0/2] git-p4: fix two undefined variables Moritz Baumann via GitGitGadget
2022-07-20 6:34 ` [PATCH 1/2] git-p4: fix typo in P4Submit.applyCommit() Moritz Baumann via GitGitGadget
2022-07-20 16:09 ` Junio C Hamano [this message]
2022-07-20 6:34 ` [PATCH 2/2] git-p4: fix error handling in P4Unshelve.renameBranch() Moritz Baumann via GitGitGadget
2022-07-20 16:18 ` Junio C Hamano
2022-07-20 16:21 ` Junio C Hamano
2022-07-20 17:01 ` Baumann, Moritz
2022-07-20 18:55 ` [PATCH v2 0/2] git-p4: fix two undefined variables Moritz Baumann via GitGitGadget
2022-07-20 18:55 ` [PATCH v2 1/2] git-p4: fix typo in P4Submit.applyCommit() Moritz Baumann via GitGitGadget
2022-07-20 18:55 ` [PATCH v2 2/2] git-p4: fix error handling in P4Unshelve.renameBranch() Moritz Baumann via GitGitGadget
2022-07-20 20:54 ` [PATCH v2 0/2] git-p4: fix two undefined variables Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqedyf4vg8.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=luke@diamand$(echo .)org \
--cc=moritz.baumann@sap$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox