From: Junio C Hamano <gitster@pobox•com>
To: "Phillip Wood via GitGitGadget" <gitgitgadget@gmail•com>
Cc: git@vger•kernel.org, "Derrick Stolee" <dstolee@microsoft•com>,
"René Scharfe" <l.s.r@web•de>, "Elijah Newren" <newren@gmail•com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx•de>,
"Derrick Stolee" <stolee@gmail•com>,
"Phillip Wood" <phillip.wood123@gmail•com>,
"Phillip Wood" <phillip.wood@dunelm•org.uk>
Subject: Re: [PATCH v3] sparse index: fix use-after-free bug in cache_tree_verify()
Date: Thu, 07 Oct 2021 14:23:13 -0700 [thread overview]
Message-ID: <xmqqee8wpm0u.fsf@gitster.g> (raw)
In-Reply-To: <pull.1053.v3.git.1633630041829.gitgitgadget@gmail.com> (Phillip Wood via GitGitGadget's message of "Thu, 07 Oct 2021 18:07:21 +0000")
"Phillip Wood via GitGitGadget" <gitgitgadget@gmail•com> writes:
> * Fixed the spelling of Stolee's name (sorry Stolee)
> * Added "-q" to the test to prevent a failure on Microsoft's fork[1]
>
> [1]
> https://lore.kernel.org/git/ebbe8616-0863-812b-e112-103680f7298b@gmail.com/
I've seen the exchange, but ...
> - for OPERATION in "merge -m merge" cherry-pick rebase
> + for OPERATION in "merge -m merge" cherry-pick "rebase --apply -q" "rebase --merge"
> do
... it looks too strange that only one of them requires a "--quiet"
option. Is it a possibility to get whoever's fork corrected so that
it behaves sensibly without requiring the "-q" option only for the
particular rebase backend?
In the meantime, I'll queue the patch as-is (I actually queued the
previous round with namefix already).
Thanks.
next prev parent reply other threads:[~2021-10-07 21:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 9:29 [PATCH] [RFC] sparse index: fix use-after-free bug in cache_tree_verify() Phillip Wood via GitGitGadget
2021-10-06 11:20 ` Derrick Stolee
2021-10-06 14:01 ` Phillip Wood
2021-10-06 14:19 ` Derrick Stolee
2021-10-06 19:17 ` Junio C Hamano
2021-10-06 20:43 ` Derrick Stolee
2021-10-07 9:50 ` [PATCH v2] " Phillip Wood via GitGitGadget
2021-10-07 13:35 ` Derrick Stolee
2021-10-07 14:59 ` Phillip Wood
2021-10-07 13:53 ` Derrick Stolee
2021-10-07 15:05 ` Phillip Wood
2021-10-07 15:44 ` Derrick Stolee
2021-10-07 17:59 ` Phillip Wood
2021-10-07 18:07 ` [PATCH v3] " Phillip Wood via GitGitGadget
2021-10-07 21:23 ` Junio C Hamano [this message]
2021-10-08 9:09 ` Phillip Wood
2021-10-08 18:53 ` Derrick Stolee
2021-10-08 19:57 ` Junio C Hamano
2021-10-14 13:34 ` Phillip Wood
2021-10-14 16:42 ` Junio C Hamano
2021-10-08 9:38 ` Bagas Sanjaya
2021-10-14 9:40 ` Phillip Wood
2021-10-16 9:07 ` [PATCH v4] " Phillip Wood via GitGitGadget
2021-10-17 5:38 ` Junio C Hamano
2021-10-17 19:35 ` Derrick Stolee
2021-10-18 9:37 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqee8wpm0u.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=dstolee@microsoft$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=l.s.r@web$(echo .)de \
--cc=newren@gmail$(echo .)com \
--cc=phillip.wood123@gmail$(echo .)com \
--cc=phillip.wood@dunelm$(echo .)org.uk \
--cc=stolee@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox