Subject: Re: [GSoC] [PATCH v2 5/9] submodule--helper: remove constness of sm_path

From: Junio C Hamano <[email-masked]>
Date: Thu, 05 Aug 2021 13:40:58 -0700

Atharva Raykar <[email-masked]> writes:

> This is needed so that it can be modified by normalize_path_copy() in
> the next patch.

This is a hard-to-judge change.  With this alone, we cannot tell if
somebody has already looked at the member (and possibly saved the
pointer elsewhere) before "the next patch" starts modifying the
member in the struct.  It probably should be done in a single patch
to demonstrate why it is needed and how existing users of the field
are OK with this change.

>
> Signed-off-by: Atharva Raykar <[email-masked]>
> Mentored-by: Christian Couder <[email-masked]>
> Mentored-by: Shourya Shukla <[email-masked]>
> ---
>  builtin/submodule--helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index 9b676c12f8..99aabf1078 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -2748,7 +2748,7 @@ struct add_data {
>  	const char *prefix;
>  	const char *branch;
>  	const char *reference_path;
> -	const char *sm_path;
> +	char *sm_path;
>  	const char *sm_name;
>  	const char *repo;
>  	const char *realrepo;