From: Junio C Hamano <gitster@pobox•com>
To: Siddharth Kannan <kannan.siddharth12@gmail•com>
Cc: Pranit Bauva <pranit.bauva@gmail•com>, Git List <git@vger•kernel.org>
Subject: Re: [PATCH v3] parse-remote: remove reference to unused op_prep
Date: Mon, 06 Feb 2017 10:17:38 -0800 [thread overview]
Message-ID: <xmqqefzb2ngd.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170206022804.GB3323@ubuntu-512mb-blr1-01.localdomain> (Siddharth Kannan's message of "Mon, 6 Feb 2017 02:28:04 +0000")
Siddharth Kannan <kannan.siddharth12@gmail•com> writes:
> Hey Pranit,
> On Sun, Feb 05, 2017 at 02:45:46AM +0530, Pranit Bauva wrote:
>> Hey Siddharth,
>>
>> On Sat, Feb 4, 2017 at 8:01 PM, Siddharth Kannan
>> <kannan.siddharth12@gmail•com> wrote:
>> > The error_on_missing_default_upstream helper function learned to
>> > take op_prep argument with 15a147e618 ("rebase: use @{upstream}
>> > if no upstream specified", 2011-02-09), but as of 045fac5845
>> > ("i18n: git-parse-remote.sh: mark strings for translation",
>> > 2016-04-19), the argument is no longer used. Remove it.
>> >
>> > Signed-off-by: Siddharth Kannan <kannan.siddharth12@gmail•com>
>>
>> This looks good to me! Thanks :)
>>
>> Regards,
>> Pranit Bauva
>
> Should I send this patch with "To:" set to Junio and "Cc:" set to the
> mailing list, as mentioend in the SubmittingPatches document?
Nah, I was watching the discussion from the sideline. I'll pick it
up after doing one final read on the patch myself.
Thanks, both.
prev parent reply other threads:[~2017-02-06 18:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-04 14:31 [PATCH v3] parse-remote: remove reference to unused op_prep Siddharth Kannan
2017-02-04 21:15 ` Pranit Bauva
2017-02-06 2:28 ` Siddharth Kannan
2017-02-06 18:17 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqefzb2ngd.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=kannan.siddharth12@gmail$(echo .)com \
--cc=pranit.bauva@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox