From: Junio C Hamano <gitster@pobox•com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 0/4] .gitignore, reinclude rules, take 2
Date: Mon, 15 Feb 2016 15:49:02 -0800 [thread overview]
Message-ID: <xmqqegcdo7pt.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1455527019-7787-1-git-send-email-pclouds@gmail.com> ("Nguyễn Thái Ngọc Duy"'s message of "Mon, 15 Feb 2016 16:03:35 +0700")
Nguyễn Thái Ngọc Duy <pclouds@gmail•com> writes:
> Take one was bad and reverted in commit 8c72236. Take two provides a
> more complete solution to the pair of rules
>
> exclude/this
> !exclude/this/except/this
>
> 3/4 should do a better job at stopping regressions in take 1. 4/4
> provides the solution. I think I have tested (and wrote tests) for all
> the cases I can imagine.
Thanks. The data structure used in 3/4 smells iffy from performance
point of view--have you tried it on a large trees with deep nesting?
>
> Nguyễn Thái Ngọc Duy (4):
> dir.c: fix match_pathname()
> dir.c: support tracing exclude
> dir.c: support marking some patterns already matched
> dir.c: don't exclude whole dir prematurely
>
> Documentation/git-check-ignore.txt | 1 +
> Documentation/git.txt | 5 +
> Documentation/gitignore.txt | 17 ++-
> dir.c | 204 +++++++++++++++++++++++++++-
> dir.h | 3 +
> t/t3001-ls-files-others-exclude.sh | 7 +-
> t/t3007-ls-files-other-negative.sh (new +x) | 153 +++++++++++++++++++++
> 7 files changed, 378 insertions(+), 12 deletions(-)
> create mode 100755 t/t3007-ls-files-other-negative.sh
prev parent reply other threads:[~2016-02-15 23:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 9:03 [PATCH 0/4] .gitignore, reinclude rules, take 2 Nguyễn Thái Ngọc Duy
2016-02-15 9:03 ` [PATCH 1/4] dir.c: fix match_pathname() Nguyễn Thái Ngọc Duy
2016-02-15 23:29 ` Junio C Hamano
2016-02-16 1:17 ` Duy Nguyen
2016-02-15 9:03 ` [PATCH 2/4] dir.c: support tracing exclude Nguyễn Thái Ngọc Duy
2016-02-15 9:03 ` [PATCH 3/4] dir.c: support marking some patterns already matched Nguyễn Thái Ngọc Duy
2016-02-15 23:47 ` Junio C Hamano
2016-02-16 1:36 ` Duy Nguyen
2016-02-15 9:03 ` [PATCH 4/4] dir.c: don't exclude whole dir prematurely Nguyễn Thái Ngọc Duy
2016-02-15 23:49 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqegcdo7pt.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox