public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: "Дилян Палаузов" <git-dpa@aegee•org>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Remove duplicate #include
Date: Fri, 13 Feb 2015 13:15:44 -0800	[thread overview]
Message-ID: <xmqqegptms1r.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1423838859-15413-1-git-send-email-git-dpa@aegee.org> ("Дилян	Палаузов"'s message of "Fri, 13 Feb 2015 14:47:39 +0000")

Дилян Палаузов  <git-dpa@aegee•org> writes:

> deheader (git://gitorious.org/deheader/deheader.git) found out that
> some .c files #include twice one and the same header file.
>
> This patch removes such occurrences and hence speeds up the compilation.

Does it speed up?  By how much?  Any numbers?

I do not see any reason to reject this change.  Removing repeated
inclusions of the same header is a good thing by itself [*1*].

Thanks.

[Footnote]

*1* If things break when repeated inclusions are removed, that would
mean the headers were wrong in the first place.  I do not think
transport.h, string-list.h, quote.h and cache.h have any reason why
they need to be included twice to work correctly, and in fact they
are designed to be no-op when included twice.

> Signed-off-by: Дилян Палаузов <git-dpa@aegee•org>
> ---
>  builtin/fetch.c    | 1 -
>  trailer.c          | 1 -
>  transport-helper.c | 1 -
>  userdiff.c         | 1 -
>  4 files changed, 4 deletions(-)
>
> diff --git a/builtin/fetch.c b/builtin/fetch.c
> index 7b84d35..75a55e5 100644
> --- a/builtin/fetch.c
> +++ b/builtin/fetch.c
> @@ -11,7 +11,6 @@
>  #include "run-command.h"
>  #include "parse-options.h"
>  #include "sigchain.h"
> -#include "transport.h"
>  #include "submodule.h"
>  #include "connected.h"
>  #include "argv-array.h"
> diff --git a/trailer.c b/trailer.c
> index 623adeb..05b3859 100644
> --- a/trailer.c
> +++ b/trailer.c
> @@ -1,7 +1,6 @@
>  #include "cache.h"
>  #include "string-list.h"
>  #include "run-command.h"
> -#include "string-list.h"
>  #include "commit.h"
>  #include "trailer.h"
>  /*
> diff --git a/transport-helper.c b/transport-helper.c
> index 0224687..3652b16 100644
> --- a/transport-helper.c
> +++ b/transport-helper.c
> @@ -5,7 +5,6 @@
>  #include "commit.h"
>  #include "diff.h"
>  #include "revision.h"
> -#include "quote.h"
>  #include "remote.h"
>  #include "string-list.h"
>  #include "thread-utils.h"
> diff --git a/userdiff.c b/userdiff.c
> index fad52d6..2ccbee5 100644
> --- a/userdiff.c
> +++ b/userdiff.c
> @@ -1,6 +1,5 @@
>  #include "cache.h"
>  #include "userdiff.h"
> -#include "cache.h"
>  #include "attr.h"
>  
>  static struct userdiff_driver *drivers;

next prev parent reply	other threads:[~2015-02-13 21:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-13 14:47 [PATCH] Remove duplicate #include Дилян Палаузов
2015-02-13 21:15 ` Junio C Hamano [this message]
2015-02-13 21:57   ` Dilyan Palauzov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqegptms1r.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git-dpa@aegee$(echo .)org \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox