From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Paul Sokolovsky <paul.sokolovsky@linaro•org>, git@vger•kernel.org
Subject: Re: [PATCH 2/2] update-server-info: create info/* with mode 0666
Date: Tue, 06 Jan 2015 13:43:33 -0800 [thread overview]
Message-ID: <xmqqegr7oa9m.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150106193950.GB28440@peff.net> (Jeff King's message of "Tue, 6 Jan 2015 14:39:51 -0500")
Jeff King <peff@peff•net> writes:
> On Tue, Jan 06, 2015 at 10:47:01AM -0800, Junio C Hamano wrote:
>
>> Jeff King <peff@peff•net> writes:
>>
>> > +test_expect_success POSIXPERM 'info/refs is readable in unshared repo' '
>> > + rm -f .git/info/refs &&
>> > + test_unconfig core.sharedrepository &&
>> > + umask 002 &&
>> > + git update-server-info &&
>> > + echo "-rw-rw-r--" >expect &&
>> > + modebits .git/info/refs >actual &&
>> > + test_cmp expect actual
>> > +'
>>
>> Hmm, the label and the test look somewhat out-of-sync. "readable as
>> long as umask allows it" would be more in line with what the fix is
>> about (i.e. I would expect a test with that title to pass even if I
>> changed 'umask 002' to 'umask 007', but that is not what we want in
>> this series).
>
> That is definitely not what the series means to accomplish. I think
> naming the test "info/refs respects umask in unshared repo" is probably
> a better title for the test.
Thanks for sanity-checking me (I am still somewhat feverish and not
performing at 100% level). Here is what I have locally (but haven't
got around to today's integration cycle yet) on top.
Subject: [PATCH] SQUASH???
---
t/t1301-shared-repo.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t1301-shared-repo.sh b/t/t1301-shared-repo.sh
index feff55e..d5eacb0 100755
--- a/t/t1301-shared-repo.sh
+++ b/t/t1301-shared-repo.sh
@@ -111,7 +111,7 @@ do
done
-test_expect_success POSIXPERM 'info/refs is readable in unshared repo' '
+test_expect_success POSIXPERM 'info/refs is created honoring the umask' '
rm -f .git/info/refs &&
test_unconfig core.sharedrepository &&
umask 002 &&
--
2.2.1-349-g24d7964
next prev parent reply other threads:[~2015-01-06 21:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 19:07 git 2.2.x: Unexpected, overstrict file permissions after "git update-server-info" Paul Sokolovsky
2015-01-05 22:23 ` Torsten Bögershausen
2015-01-06 3:47 ` Jeff King
2015-01-06 3:49 ` [PATCH 1/2] t1301: set umask in reflog sharedrepository=group test Jeff King
2015-01-06 3:50 ` [PATCH 2/2] update-server-info: create info/* with mode 0666 Jeff King
2015-01-06 18:47 ` Junio C Hamano
2015-01-06 19:39 ` Jeff King
2015-01-06 21:43 ` Junio C Hamano [this message]
2015-01-06 21:47 ` Jeff King
2015-01-06 10:08 ` git 2.2.x: Unexpected, overstrict file permissions after "git update-server-info" Junio C Hamano
2015-01-06 12:43 ` Paul Sokolovsky
2015-01-06 18:44 ` Junio C Hamano
2015-01-06 19:37 ` Jeff King
2015-01-06 12:12 ` Paul Sokolovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqegr7oa9m.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=paul.sokolovsky@linaro$(echo .)org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox