From: Junio C Hamano <gitster@pobox•com>
To: Paul Smith <paul@mad-scientist•net>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] git-new-workdir: Don't fail if the target directory is empty
Date: Fri, 21 Nov 2014 09:33:08 -0800 [thread overview]
Message-ID: <xmqqegsw1msr.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1416582517.23953.18.camel@mad-scientist.net> (Paul Smith's message of "Fri, 21 Nov 2014 10:08:37 -0500")
Paul Smith <paul@mad-scientist•net> writes:
>> Why these changes? I thought you are making sure $cleandir is
>> absolute so that you do not have to do this and can just "cd" into
>> the new working tree, the same way the user would do once it is set
>> up.
>
> I made cleandir absolute mainly because you asked me to :-). I didn't
> realize that the implication behind that request was that I'd put back
> the original "cd" as well.
This is about not changing unnecessarily the original that has been
battle-tested and keeping the result resistant to future mistakes
(i.e. somebody going elsewhere without realizing a relative cleandir
will cause problems). Once $cleandir is fixed, there no longer is a
good reason to change how HEAD is pointed in the $new_workdir or its
working tree populated; the change in the earlier round in that area
was necessary when $cleandir was not absolute, but not anymore.
next prev parent reply other threads:[~2014-11-21 17:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 15:46 [PATCH] git-new-workdir: Don't fail if the target directory is empty Paul Smith
2014-11-20 17:13 ` Junio C Hamano
2014-11-21 15:08 ` Paul Smith
2014-11-21 17:33 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-11-18 19:36 Paul Smith
2014-11-18 20:15 ` Junio C Hamano
2014-11-19 17:32 ` Junio C Hamano
2014-11-20 15:41 ` Paul Smith
2014-11-15 17:49 Paul Smith
2014-11-17 17:22 ` Junio C Hamano
2014-11-18 17:46 ` Paul Smith
2014-11-18 19:32 ` Junio C Hamano
2014-11-18 20:54 ` Paul Smith
2014-11-18 20:58 ` Junio C Hamano
2014-11-18 22:25 ` Paul Smith
2014-11-18 22:51 ` Junio C Hamano
2014-11-19 0:57 ` Paul Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqegsw1msr.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=paul@mad-scientist$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox