From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: "Heiko Voigt" <hvoigt@hvoigt•net>, "René Scharfe" <l.s.r@web•de>,
"Git Mailing List" <git@vger•kernel.org>,
"Etienne Buira" <etienne.buira@gmail•com>
Subject: Re: [PATCH] run-command: use void to declare that functions take no parameters
Date: Tue, 11 Nov 2014 09:32:40 -0800 [thread overview]
Message-ID: <xmqqegt97idj.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20141111025415.GB21328@peff.net> (Jeff King's message of "Mon, 10 Nov 2014 21:54:15 -0500")
Jeff King <peff@peff•net> writes:
> I had always just assumed that -Wstrict-prototypes was part of -Wall,
> but it is not (nor even part of -Wextra!). Maybe it is time to add it to
> your integration-build flags. :)
Yup, I had -Wold-style-definition but not -Wstrict-prototypes in the
mix. Thanks for spotting.
>
> Looks like we also need this on top of hv/submodule-config (still in pu,
> so squashing is probably best):
>
> diff --git a/submodule-config.h b/submodule-config.h
> index 58afc83..9061e4e 100644
> --- a/submodule-config.h
> +++ b/submodule-config.h
> @@ -24,6 +24,6 @@ const struct submodule *submodule_from_name(const unsigned char *commit_sha1,
> const char *name);
> const struct submodule *submodule_from_path(const unsigned char *commit_sha1,
> const char *path);
> -void submodule_free();
> +void submodule_free(void);
>
> #endif /* SUBMODULE_CONFIG_H */
>
> -Peff
prev parent reply other threads:[~2014-11-11 17:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 21:17 [PATCH] run-command: use void to declare that functions take no parameters René Scharfe
2014-11-10 22:43 ` Junio C Hamano
2014-11-11 2:54 ` Jeff King
2014-11-11 17:32 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqegt97idj.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=etienne.buira@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=hvoigt@hvoigt$(echo .)net \
--cc=l.s.r@web$(echo .)de \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox