public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: "Torsten Bögershausen" <tboegi@web•de>
Cc: Hilco Wijbenga <hilco.wijbenga@gmail•com>,
	Git Users <git@vger•kernel.org>
Subject: Re: [PATCH] init - Honour the global core.filemode setting
Date: Fri, 03 Oct 2014 10:07:16 -0700	[thread overview]
Message-ID: <xmqqegupm69n.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <542ED4B8.40603@web.de> ("Torsten Bögershausen"'s message of "Fri, 03 Oct 2014 18:54:16 +0200")

Torsten Bögershausen <tboegi@web•de> writes:

>> The first sentence says what happens, as it should.
>> 
>> But it is not directly clear what makes the executable bit differ
>> and when it is a useful thing to ignore the differences, so the
>> second sentence that says "This may be useful" does not give the
>> reader very much.
>> 
> Clearly a major improvement.
>
> Does this (still) include the original line
> "See linkgit:git-update-index[1]"
>
> which helps the user to add *.sh files "executable" to the index, even if
> core.filemode is false ?

Thanks for catching; I omitted the reference by accident.

Perhaps end that sentence like this instead?

	... may be necessary to set this variable to `false`, and
	maintain the executable bit with `git update-index --chmod`
	(see linkgit:git-update-index[1]).

      reply	other threads:[~2014-10-03 17:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-28  0:37 [PATCH] init - Honour the global core.filemode setting Hilco Wijbenga
2014-09-28 11:52 ` Torsten Bögershausen
2014-10-01  1:55   ` Hilco Wijbenga
2014-10-01 17:10     ` Junio C Hamano
2014-10-02 11:15       ` Torsten Bögershausen
2014-10-02 17:02         ` Junio C Hamano
2014-10-03 16:54           ` Torsten Bögershausen
2014-10-03 17:07             ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqegupm69n.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=hilco.wijbenga@gmail$(echo .)com \
    --cc=tboegi@web$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox