Subject: Re: [RFH] renaming strcmp/strncmp-icase

From: Junio C Hamano <[email-masked]>
Date: Mon, 08 Sep 2014 12:56:01 -0700

Torsten Bögershausen <[email-masked]> writes:

> And then we have this in name-hash.c:
> (Which may explain the "icase" suffix ?)
>
> static int same_name(const struct cache_entry *ce, const char *name, int namelen, int icase)

As this file-scope static function takes the "icase" as an explicit
argument, I do not see anything confusing about it.  My complaint
was it is confusing that str[n]cmp_icase is not always icase, even
though the name of the function implies that it would be to those
who haven't looked at its implementation for a while.