From: Junio C Hamano <gitster@pobox•com>
To: Torstein Hegge <hegge@resisty•net>
Cc: git@vger•kernel.org, Jiang Xin <worldhello.net@gmail•com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
Subject: Re: [PATCH] branch: fix --verbose output column alignment
Date: Mon, 18 Nov 2013 11:27:15 -0800 [thread overview]
Message-ID: <xmqqeh6dbje4.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1384453081-7679-1-git-send-email-hegge@resisty.net> (Torstein Hegge's message of "Thu, 14 Nov 2013 19:18:01 +0100")
Torstein Hegge <hegge@resisty•net> writes:
> Commit f2e0873 (branch: report invalid tracking branch as gone) removed
> an early return from fill_tracking_info() in the path taken when 'git
> branch -v' lists a branch in sync with its upstream. This resulted in an
> unconditionally added space in front of the subject line:
>
> $ git branch -v
> * master f5eb3da commit pushed to upstream
> topic f935eb6 unpublished topic
>
> Instead, only add the trailing space if a decoration have been added.
>
> To catch this kind of whitespace breakage in the tests, be a bit less
> smart when filtering the output through sed.
>
> Signed-off-by: Torstein Hegge <hegge@resisty•net>
> ---
Thanks.
prev parent reply other threads:[~2013-11-18 19:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 18:18 [PATCH] branch: fix --verbose output column alignment Torstein Hegge
2013-11-15 1:45 ` Jiang Xin
2013-11-18 19:27 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqeh6dbje4.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=hegge@resisty$(echo .)net \
--cc=worldhello.net@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox