From: Junio C Hamano <gitster@pobox•com>
To: Ben Walton <bdwalton@gmail•com>
Cc: Andreas Schwab <schwab@linux-m68k•org>, git <git@vger•kernel.org>
Subject: Re: [PATCH] Change sed i\ usage to something Solaris' sed can handle
Date: Wed, 30 Oct 2013 12:30:22 -0700 [thread overview]
Message-ID: <xmqqeh72blpt.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAP30j15+E4cz_kwJwaSH7-3agwC5J3jGNfaixSUg2=8xAzZoQg@mail.gmail.com> (Ben Walton's message of "Mon, 28 Oct 2013 21:10:46 +0000")
Ben Walton <bdwalton@gmail•com> writes:
> On Mon, Oct 28, 2013 at 5:39 PM, Andreas Schwab <schwab@linux-m68k•org> wrote:
>> Ben Walton <bdwalton@gmail•com> writes:
>>
>>> diff --git a/t/t4015-diff-whitespace.sh b/t/t4015-diff-whitespace.sh
>>> index 3fb4b97..0126154 100755
>>> --- a/t/t4015-diff-whitespace.sh
>>> +++ b/t/t4015-diff-whitespace.sh
>>> @@ -145,7 +145,8 @@ test_expect_success 'another test, with --ignore-space-at-eol' 'test_cmp expect
>>> test_expect_success 'ignore-blank-lines: only new lines' '
>>> test_seq 5 >x &&
>>> git update-index x &&
>>> - test_seq 5 | sed "/3/i \\
>>> + test_seq 5 | sed "/3/i\\
>>> +\
>>> " >x &&
>>
>> Why do you need the \<nl>? Since it is inside double quotes the shell
>> will remove it during expansion.
>
> It's an escape. Without it, sed throws:
>
> sed: -e expression #1, char 5: expected \ after `a', `c' or `i'
I think Andreas means the "feed blank line" part, i.e.
>> + test_seq 5 | sed "/3/i\\
>> +\
>> " >x &&
should be the same as
>> + test_seq 5 | sed "/3/i\\
>> " >x &&
because the lone \<nl> will be eaten and will not be seen by sed.
Do you see different results on Solaris between the following two?
$ echo "/3/i\\
\
" | od
$ echo "/3/i\\
" | od
next prev parent reply other threads:[~2013-10-30 19:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-27 21:26 [PATCH] Change sed i\ usage to something Solaris' sed can handle Ben Walton
2013-10-28 17:39 ` Andreas Schwab
2013-10-28 21:10 ` Ben Walton
2013-10-28 21:59 ` Andreas Schwab
2013-10-30 19:30 ` Junio C Hamano [this message]
2013-11-03 13:08 ` Ben Walton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqeh72blpt.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=bdwalton@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=schwab@linux-m68k$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox