From: Junio C Hamano <gitster@pobox•com>
To: Sebastian Schuberth <sschuberth@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] GIT-VERSION-GEN: Do not require tags to be annotated
Date: Fri, 06 Sep 2013 14:40:41 -0700 [thread overview]
Message-ID: <xmqqeh91wrvq.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <522A36AA.3050701@gmail.com> (Sebastian Schuberth's message of "Fri, 06 Sep 2013 22:10:18 +0200")
Sebastian Schuberth <sschuberth@gmail•com> writes:
> For custom builds of Git it sometimes is inconvenient to annotate tags
> because there simply is nothing to say, so do not require an annotation.
>
> Signed-off-by: Sebastian Schuberth <sschuberth@gmail•com>
> ---
Hmmmm, personally I'd actually want this to stay the way it is, or
even require a valid signed tag, in order to make sure I won't
mistakenly creating a lightweight tag.
If you want to give build a custom name,
echo buildname >version
should be sufficient, no?
I dunno.
> GIT-VERSION-GEN | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN
> index b444c18..68b61e3 100755
> --- a/GIT-VERSION-GEN
> +++ b/GIT-VERSION-GEN
> @@ -12,7 +12,7 @@ if test -f version
> then
> VN=$(cat version) || VN="$DEF_VER"
> elif test -d ${GIT_DIR:-.git} -o -f .git &&
> - VN=$(git describe --match "v[0-9]*" --abbrev=7 HEAD 2>/dev/null) &&
> + VN=$(git describe --tags --match "v[0-9]*" --abbrev=7 HEAD 2>/dev/null) &&
> case "$VN" in
> *$LF*) (exit 1) ;;
> v[0-9]*)
next prev parent reply other threads:[~2013-09-06 21:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 20:10 [PATCH] GIT-VERSION-GEN: Do not require tags to be annotated Sebastian Schuberth
2013-09-06 21:40 ` Junio C Hamano [this message]
2013-09-07 0:37 ` Felipe Contreras
[not found] ` <CAJDDKr4JBeccwuD4PVq0ryO27Eyfz+yUAHT7xm0Dkh19SZpV4g@mail.gmail.com>
2013-09-08 0:58 ` Felipe Contreras
2013-09-07 12:28 ` Sebastian Schuberth
2013-09-07 16:10 ` Junio C Hamano
2013-09-07 19:47 ` Sebastian Schuberth
2013-09-08 17:41 ` Junio C Hamano
2013-09-09 23:21 ` Felipe Contreras
2013-09-10 8:06 ` Sebastian Schuberth
2013-09-10 9:53 ` Felipe Contreras
2013-09-10 15:59 ` Junio C Hamano
2013-09-10 19:45 ` Sebastian Schuberth
2013-09-08 0:54 ` Felipe Contreras
2013-09-06 22:34 ` Kyle J. McKay
2013-09-07 12:26 ` Sebastian Schuberth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqeh91wrvq.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=sschuberth@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox