From: Junio C Hamano <gitster@pobox•com>
To: Eric Sunshine <sunshine@sunshineco•com>
Cc: Timur Tabi <timur@kernel•org>, git <git@vger•kernel.org>
Subject: Re: [BUG] suppress-cc does not support multiple keywords
Date: Wed, 13 Aug 2025 07:33:11 -0700 [thread overview]
Message-ID: <xmqqfrdvp9zs.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cTvCLU3u5y23HSrbxovs8cjcJdOUj0e1G9Rg4F1AP0jAg@mail.gmail.com> (Eric Sunshine's message of "Wed, 13 Aug 2025 02:34:45 -0400")
Eric Sunshine <sunshine@sunshineco•com> writes:
> ... If there is any "bug", it's that the documentation does state
> that you can specify --suppress-cc multiple times (even though you
> obviously can).
>
> [*]: https://git-scm.com/docs/git-send-email#Documentation/git-send-email.txt---suppress-cccategory
"does state"? or "does not state" or "does state that you cannot"?
I guess you meant the second one; some other options like --to
explicitly say "multiple times", but many others, this one among
them, does not.
The existing text
--suppress-cc=<category>::
Specify an additional category of recipients to suppress the
auto-cc of:
does make it clear that <category> given to a single instance of
this option is a single category ("AN additional category").
Perhaps a minimum fix would be something like this?
Documentation/git-send-email.adoc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git c/Documentation/git-send-email.adoc w/Documentation/git-send-email.adoc
index 5335502d68..b959e39257 100644
--- c/Documentation/git-send-email.adoc
+++ w/Documentation/git-send-email.adoc
@@ -403,7 +403,9 @@ Automating
- `all` will suppress all auto cc values.
--
+
-Default is the value of `sendemail.suppressCc` configuration value; if
+Can be given more than once to suppress multiple categories.
+Default is the value of `sendemail.suppressCc` configuration
+variable (which can be given multiple times, one category at a time); if
that is unspecified, default to `self` if `--suppress-from` is
specified, as well as `body` if `--no-signed-off-cc` is specified.
next prev parent reply other threads:[~2025-08-13 14:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 0:05 [BUG] suppress-cc does not support multiple keywords Timur Tabi
2025-08-13 6:34 ` Eric Sunshine
2025-08-13 14:33 ` Junio C Hamano [this message]
2025-08-13 15:38 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfrdvp9zs.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=sunshine@sunshineco$(echo .)com \
--cc=timur@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox