From: Junio C Hamano <gitster@pobox•com>
To: "brian m. carlson" <sandals@crustytoothpaste•net>
Cc: <git@vger•kernel.org>, Taylor Blau <me@ttaylorr•com>,
Yi EungJun <eungjun.yi@navercorp•com>
Subject: Re: [PATCH 0/1] Filter C and POSIX out of Accept-Language
Date: Thu, 10 Jul 2025 15:45:20 -0700 [thread overview]
Message-ID: <xmqqfrf34qdb.fsf@gitster.g> (raw)
In-Reply-To: <20250710221641.857081-1-sandals@crustytoothpaste.net> (brian m. carlson's message of "Thu, 10 Jul 2025 22:16:40 +0000")
"brian m. carlson" <sandals@crustytoothpaste•net> writes:
> At work, I've seen some cases where people provide "C" in the
> Accept-Language header of their Git requests, such as when they provide
> us with debugging traces, but "C" and "POSIX", while valid locales, are
> not valid languages and do not belong in the Accept-Language header.
>
> It turns out this is actually very easy to reproduce and fix, so there's
> a patch to filter these out. I have not actually myself seen "POSIX" in
> the header, but it's equivalent to "C" and I've seen it in non-Git
> requests in various places online, so we reject that as well.
>
> This can be seen in GitLab's issues as well at
> https://gitlab.com/gitlab-org/gitlab/-/issues/412077.
Sorry, I am confused. Is that Authentication failure in the cited
issue "caused by" the client sending "Accept-Language: C"?
"reproduce and fix" makes it sound like a correct exchange between
such a client and a server is somehow broken (i.e. unable to clone,
unable to authenticate, etc.) if the client sends C (or POSIX) as if
it were a langauge, but is there a breakage there?
I understand and agree with the change in patch 1/1 that it is the
right thing to do (to more strictly adhere to the standard in what
we send out) for hygiene. I just want to understand if this caused
real problems, or if it is primarily a preemptive clean-up to avoid
non-standard behaviour causing problems in the future.
Thanks.
> brian m. carlson (1):
> http: don't send C or POSIX in Accept-Language
>
> http.c | 8 ++++++++
> t/t5541-http-push-smart.sh | 18 ++++++++++++++++++
> 2 files changed, 26 insertions(+)
next prev parent reply other threads:[~2025-07-10 22:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 22:16 [PATCH 0/1] Filter C and POSIX out of Accept-Language brian m. carlson
2025-07-10 22:16 ` [PATCH 1/1] http: don't send C or POSIX in Accept-Language brian m. carlson
2025-07-10 22:47 ` Junio C Hamano
2025-07-10 23:08 ` brian m. carlson
2025-07-11 15:23 ` Justin Tobler
2025-07-11 17:02 ` Collin Funk
2025-07-11 20:57 ` Carlo Marcelo Arenas Belón
2025-07-11 21:29 ` brian m. carlson
2025-07-11 22:12 ` Carlo Arenas
2025-07-11 22:17 ` Collin Funk
2025-07-11 18:32 ` Junio C Hamano
2025-07-11 20:22 ` Carlo Marcelo Arenas Belón
2025-07-15 4:38 ` Eli Schwartz
2025-07-10 22:45 ` Junio C Hamano [this message]
2025-07-10 23:08 ` [PATCH 0/1] Filter C and POSIX out of Accept-Language brian m. carlson
2025-07-10 23:26 ` Collin Funk
2025-07-11 2:49 ` [External] " Han Young
2025-07-11 16:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfrf34qdb.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=eungjun.yi@navercorp$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=me@ttaylorr$(echo .)com \
--cc=sandals@crustytoothpaste$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox