Subject: Re: [PATCH] submodule status: propagate SIGPIPE

From: Junio C Hamano <[email-masked]>
Date: Fri, 20 Sep 2024 13:06:08 -0700

"Phillip Wood via GitGitGadget" <[email-masked]> writes:

> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index a46ffd49b34..a8e497ef3c6 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -30,6 +30,7 @@
>  #include "advice.h"
>  #include "branch.h"
>  #include "list-objects-filter-options.h"
> +#include <signal.h>

Do we really need this?

As with any other Git built-in that relies on git-compat-util.h to
handle such system-dependencies, direct inclusion of system headers
like this is highly questionable.