Subject: Re: [PATCH v2 2/4] config: report config parse errors using cb

From: Junio C Hamano <[email-masked]>
Date: Thu, 24 Aug 2023 11:48:24 -0700

Jonathan Tan <[email-masked]> writes:

> Junio C Hamano <[email-masked]> writes:
>> > @@ -1035,8 +1088,6 @@ static int git_parse_source(struct config_source *cs, config_fn_t fn,
>> >  	int comment = 0;
>> >  	size_t baselen = 0;
>> >  	struct strbuf *var = &cs->var;
>> > ...
>> > +	/*
>> > +	 * FIXME for whatever reason, do_event passes the _previous_ event, so
>> > +	 * in order for our callback to receive the error event, we have to call
>> > +	 * do_event twice
>> > +	 */
>> > +	do_event(cs, CONFIG_EVENT_ERROR, &event_data);
>> > +	do_event(cs, CONFIG_EVENT_ERROR, &event_data);
>> > +	return -1;
>> >  }
>> 
>> This indeed is very curious and needs to be looked into before we
>> proceed further.  How does the current control flow cope with the
>> behaviour?
>
> I plan to look at this more fully later, but about this, I wrote about
> this in a reply to the previous version:
> https://lore.kernel.org/git/[email-masked]/

Thanks.

Also if you have time, can you comment on the latest round of the
fix to the Bloom filter hash functions that Taylor sent the latest
iteration for, either to give it a "looks perfect" to nudge it to
merge it down, to give it a further polishing, or whatever.  Thanks.