Subject: Re: [PATCH 06/15] apply tests: use "test_must_fail" instead of ad-hoc pattern

From: Junio C Hamano <[email-masked]>
Date: Wed, 02 Mar 2022 15:09:48 -0800

Ævar Arnfjörð Bjarmason  <[email-masked]> writes:

>  test_expect_success 'apply should fail gracefully' '
> -
> -	if git apply --index patch
> -	then
> -		echo Oops, should not have succeeded
> -		false
> -	else
> -		status=$? &&
> -		echo "Status was $status" &&
> -		if test -f .git/index.lock
> -		then
> -			echo Oops, should not have crashed
> -			false
> -		fi
> -	fi
> +	test_must_fail git apply --index patch &&
> +	test_path_is_missing .git/index.lock
>  '

Wow, that is very old fashioned.  Thanks for cleaning up the
leftover mess from the days before test_must_fail was prevalent.