From: Junio C Hamano <gitster@pobox•com>
To: Shourya Shukla <periperidip@gmail•com>
Cc: git@vger•kernel.org, Johannes.Schindelin@gmx•de,
liu.denton@gmail•com, christian.couder@gmail•com,
kaartic.sivaraam@gmail•com
Subject: Re: [PATCH v3 0/3] submodule: port subcommand add from shell to C
Date: Tue, 22 Dec 2020 15:42:32 -0800 [thread overview]
Message-ID: <xmqqft3xflw7.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20201214231939.644175-1-periperidip@gmail.com> (Shourya Shukla's message of "Tue, 15 Dec 2020 04:49:36 +0530")
Shourya Shukla <periperidip@gmail•com> writes:
> Feedback and reviews are appreciated.
>
> Regards,
> Shourya Shukla
>
> Shourya Shukla (3):
> dir: change the scope of function 'directory_exists_in_index()'
> submodule: port submodule subcommand 'add' from shell to C
> t7400: add test to check 'submodule add' for tracked paths
Sorry for not being a feedback nor a review, but we are seeing a
segfault from "git submodule add" when the topic is tested with the
rest of 'seen':
https://github.com/git/git/runs/1597682274#step:6:3155
It seems that you need to be logged in to see the full CI output to
the line level when visiting the above URL.
Thanks.
prev parent reply other threads:[~2020-12-22 23:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 23:19 [PATCH v3 0/3] submodule: port subcommand add from shell to C Shourya Shukla
2020-12-14 23:19 ` [PATCH v3 1/3] dir: change the scope of function 'directory_exists_in_index()' Shourya Shukla
2020-12-19 0:08 ` Johannes Schindelin
2020-12-19 0:47 ` Junio C Hamano
2020-12-14 23:19 ` [PATCH v3 2/3] submodule: port submodule subcommand 'add' from shell to C Shourya Shukla
2020-12-14 23:19 ` [PATCH v3 3/3] t7400: add test to check 'submodule add' for tracked paths Shourya Shukla
2020-12-15 21:44 ` [PATCH v3 0/3] submodule: port subcommand add from shell to C Junio C Hamano
2020-12-17 14:16 ` Shourya Shukla
2020-12-17 22:20 ` Junio C Hamano
2020-12-22 23:42 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqft3xflw7.fsf@gitster.c.googlers.com \
--to=gitster@pobox$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=kaartic.sivaraam@gmail$(echo .)com \
--cc=liu.denton@gmail$(echo .)com \
--cc=periperidip@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox