From: Junio C Hamano <gitster@pobox•com>
To: Eric Sunshine <sunshine@sunshineco•com>
Cc: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail•com>,
"Git List" <git@vger•kernel.org>,
"SZEDER Gábor" <szeder.dev@gmail•com>,
"Johannes Schindelin" <johannes.schindelin@gmx•de>
Subject: Re: [PATCH v2 2/2] tests: introduce --stress-jobs=<N>
Date: Mon, 04 Mar 2019 12:22:39 +0900 [thread overview]
Message-ID: <xmqqfts3z5kw.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAPig+cS1URdnRb0RM0HYQhtmXWn5knx6Ee1Y96Gc9dt_9LmRKA@mail.gmail.com> (Eric Sunshine's message of "Sun, 3 Mar 2019 10:00:32 -0500")
Eric Sunshine <sunshine@sunshineco•com> writes:
> On Sun, Mar 3, 2019 at 9:45 AM Johannes Schindelin via GitGitGadget
> <gitgitgadget@gmail•com> wrote:
>> [...]
>> Let's introduce a separate option for that, whose name makes it more
>> obvious what it is about, and let --stress=<N> error out with a helpful
>> suggestion about the two options tha could possibly have been meant.
>>
>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx•de>
>> ---
>> diff --git a/t/README b/t/README
>> @@ -187,11 +187,10 @@ appropriately before running "make".
>> variable to "1" or "0", respectively.
>>
>> --stress::
>> ---stress=<N>::
>
> Shouldn't the "--stress=<N>" line be removed?
Eyes can easily be tricked by the patch format, but the above hunk
does remove that line ;-) I had the same reaction when I saw your
message for the first time (before seeing the patch itself).
>
>> Run the test script repeatedly in multiple parallel jobs until
>> one of them fails. Useful for reproducing rare failures in
>> flaky tests. The number of parallel jobs is, in order of
>> - precedence: <N>, or the value of the GIT_TEST_STRESS_LOAD
>> + precedence: the value of the GIT_TEST_STRESS_LOAD
>> environment variable, or twice the number of available
>> processors (as shown by the 'getconf' utility), or 8.
next prev parent reply other threads:[~2019-03-04 3:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 21:19 [PATCH 0/2] tests: some touchups related to the --stress feature Johannes Schindelin via GitGitGadget
2019-03-02 21:19 ` [PATCH 1/2] tests: let --stress-limit=<N> imply --stress Johannes Schindelin via GitGitGadget
2019-03-03 9:54 ` Junio C Hamano
2019-03-02 21:19 ` [PATCH 2/2] tests: introduce --stress-jobs=<N> Johannes Schindelin via GitGitGadget
2019-03-03 2:30 ` Eric Sunshine
2019-03-03 9:55 ` Junio C Hamano
2019-03-03 14:19 ` SZEDER Gábor
2019-03-03 14:47 ` Johannes Schindelin
2019-03-03 14:44 ` [PATCH v2 0/2] tests: some touchups related to the --stress feature Johannes Schindelin via GitGitGadget
2019-03-03 14:44 ` [PATCH v2 1/2] tests: let --stress-limit=<N> imply --stress Johannes Schindelin via GitGitGadget
2019-03-03 14:44 ` [PATCH v2 2/2] tests: introduce --stress-jobs=<N> Johannes Schindelin via GitGitGadget
2019-03-03 15:00 ` Eric Sunshine
2019-03-04 3:22 ` Junio C Hamano [this message]
2019-03-04 3:55 ` Eric Sunshine
2019-03-03 17:45 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfts3z5kw.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=sunshine@sunshineco$(echo .)com \
--cc=szeder.dev@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox