From: Junio C Hamano <gitster@pobox•com>
To: ryenus <ryenus@gmail•com>
Cc: Git mailing list <git@vger•kernel.org>,
Andreas Heiduk <asheiduk@gmail•com>
Subject: Re: [PATCH v2] update revisions doc for quoting in ':/' notation
Date: Thu, 17 Aug 2017 13:58:29 -0700 [thread overview]
Message-ID: <xmqqfucpgbd6.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAKkAvax4Coqa6=jT52dpy4SYycfwoN-6kGfoh3QPLJi2-69Orw@mail.gmail.com> (ryenus@gmail.com's message of "Thu, 17 Aug 2017 14:54:44 +0800")
ryenus <ryenus@gmail•com> writes:
> To make sure the `<text>` in `:/<text>` is seen as one search string,
> one should quote/escape `<text>` properly.
>
> Especially, the example given in the manual `:/fix nasty bug` does not
> work because of missing quotes when used in shell. A note about
> quoting/escaping is added along with a working example, however, the
> original example is left-as-is to be consistent with other examples.
>
> Signed-off-by: ryenus <ryenus@gmail•com>
> ---
> Documentation/revisions.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/revisions.txt b/Documentation/revisions.txt
> index 61277469c..d2862d55d 100644
> --- a/Documentation/revisions.txt
> +++ b/Documentation/revisions.txt
> @@ -185,7 +185,9 @@ existing tag object.
> e.g. ':/^foo'. The special sequence ':/!' is reserved for modifiers to what
> is matched. ':/!-foo' performs a negative match, while ':/!!foo' matches a
> literal '!' character, followed by 'foo'. Any other sequence beginning with
> - ':/!' is reserved for now.
> + ':/!' is reserved for now. And make sure to quote/escape for the text to be
> + interpreted as the expected search string/pattern, e.g., for a commit whose
> + message matches a literal \'`$`', use `git show :/\\\$` or `git show ':/\$'`.
Hmph.
This seems to miss the most important point Andreas raised, which is
that the way to quote them is entirely up to the shell and other UI
machinery the user is using.
And I am not sure if those who are using CUI should be told about
shell's quoting rules when they are learning about :/ syntax. There
are tons of other ways that the user needs to pass a string with
whitespace in it as a single argument to commands, many of which may
not even be related to Git at all. I was actually expecting a much
milder text, perhaps literal copy of what Andreas gave you in his
message <956ccc83-c291-4217-795c-fcef33fac35b@gmail•com>.
By the way, I do not mean to dictate what name and address you use
to communicate with other people, but especially with something that
is supposed to hopefully have some legal value down the line if
somebody starts making SCO noises, it really would be nice to have a
real person to associate things with recorded as the author of a
change and the person who signed off the patch. It would be
embarrassing later if there is no way to even look you up somehow.
Thanks.
prev parent reply other threads:[~2017-08-17 20:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 6:54 [PATCH v2] update revisions doc for quoting in ':/' notation ryenus
2017-08-17 20:58 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfucpgbd6.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=asheiduk@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=ryenus@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox