From: Junio C Hamano <gitster@pobox•com>
To: Jacob Keller <jacob.e.keller@intel•com>
Cc: git@vger•kernel.org, Johannes Sixt <j6t@kdbg•org>,
Johannes Schindelin <johannes.schindelin@gmx•de>,
Jacob Keller <jacob.keller@gmail•com>
Subject: Re: [PATCH v4 2/5] name-rev: extend --refs to accept multiple patterns
Date: Thu, 19 Jan 2017 13:06:46 -0800 [thread overview]
Message-ID: <xmqqfukezrmh.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170118230608.28030-3-jacob.e.keller@intel.com> (Jacob Keller's message of "Wed, 18 Jan 2017 15:06:05 -0800")
Jacob Keller <jacob.e.keller@intel•com> writes:
> From: Jacob Keller <jacob.keller@gmail•com>
>
> Teach git name-rev to take multiple --refs stored as a string list of
> patterns. The list of patterns will be matched inclusively, and each ref
> only needs to match one pattern to be included. A ref will only be
> excluded if it does not match any of the given patterns. Additionally,
> if any of the patterns would allow abbreviation, then we will abbreviate
> the ref, even if another pattern is more strict and would not have
> allowed abbreviation on its own.
>
> Add tests and documentation for this change. The tests expected output
> is dynamically generated, but this is in order to avoid hard-coding
> a commit object id in the test results (as the expected output is to
> simply leave the commit object unnamed).
Makes sense.
I do not see anything that requires "... generated, but" there,
though, as if it is a bad thing to do to prepare expected output
dynamically. I'd just reword "generated. This is..." to make it
neutral.
next prev parent reply other threads:[~2017-01-19 21:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 23:06 [PATCH v4 0/5] extend git-describe pattern matching Jacob Keller
2017-01-18 23:06 ` [PATCH v4 1/5] doc: add documentation for OPT_STRING_LIST Jacob Keller
2017-01-18 23:06 ` [PATCH v4 2/5] name-rev: extend --refs to accept multiple patterns Jacob Keller
2017-01-19 21:03 ` Junio C Hamano
2017-01-19 21:06 ` Junio C Hamano [this message]
2017-01-19 23:36 ` Jacob Keller
2017-01-19 23:45 ` Jacob Keller
2017-01-18 23:06 ` [PATCH v4 3/5] name-rev: add support to exclude refs by pattern match Jacob Keller
2017-01-19 21:08 ` Junio C Hamano
2017-01-18 23:06 ` [PATCH v4 4/5] describe: teach --match to accept multiple patterns Jacob Keller
2017-01-18 23:06 ` [PATCH v4 5/5] describe: teach describe negative pattern matches Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfukezrmh.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=j6t@kdbg$(echo .)org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jacob.keller@gmail$(echo .)com \
--cc=johannes.schindelin@gmx$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox