From: Junio C Hamano <gitster@pobox•com>
To: Stefan Beller <sbeller@google•com>
Cc: pclouds@gmail•com, bmwill@google•com, git@vger•kernel.org
Subject: Re: [PATCH 0/2] improve relocate_git_dir to fail into a sane state.
Date: Mon, 19 Dec 2016 14:54:34 -0800 [thread overview]
Message-ID: <xmqqfuljmswl.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161219215709.24620-1-sbeller@google.com> (Stefan Beller's message of "Mon, 19 Dec 2016 13:57:07 -0800")
Stefan Beller <sbeller@google•com> writes:
> This goes on top of sb/submodule-embed-gitdir.
> When the absorbing of a git dir fails, try to recover into a sane state,
> i.e. try to undo the move of the git dir.
Are these unconditionally good improvements? I ask because the
series is still not in 'next' and it is the last chance to fold
these into existing patches if we wanted to.
>
> Thanks,
> Stefan
>
> Stefan Beller (2):
> dir.c: split up connect_work_tree_and_git_dir
> dir.c: add retry logic to relocate_gitdir
>
> dir.c | 118 +++++++++++++++++++++++++++++++++++++++++++++++++++++-------
> dir.h | 6 ++--
> submodule.c | 3 +-
> 3 files changed, 110 insertions(+), 17 deletions(-)
next prev parent reply other threads:[~2016-12-19 22:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 21:57 [PATCH 0/2] improve relocate_git_dir to fail into a sane state Stefan Beller
2016-12-19 21:57 ` [PATCH 1/2] dir.c: split up connect_work_tree_and_git_dir Stefan Beller
2016-12-19 21:57 ` [PATCH 2/2] dir.c: add retry logic to relocate_gitdir Stefan Beller
2016-12-19 22:25 ` Brandon Williams
2016-12-19 23:19 ` Stefan Beller
2017-01-04 13:34 ` Duy Nguyen
2016-12-19 22:54 ` Junio C Hamano [this message]
2016-12-19 23:14 ` [PATCH 0/2] improve relocate_git_dir to fail into a sane state Stefan Beller
2016-12-19 23:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfuljmswl.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=bmwill@google$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox