From: Junio C Hamano <gitster@pobox•com>
To: Ramsay Jones <ramsay@ramsayjones•plus.com>
Cc: Michael Haggerty <mhagger@alum•mit.edu>,
GIT Mailing-list <git@vger•kernel.org>
Subject: Re: [PATCH] refs: mark the file-local vtable symbols as static
Date: Wed, 08 Jun 2016 11:55:55 -0700 [thread overview]
Message-ID: <xmqqfusnldc4.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <57583022.2030205@ramsayjones.plus.com> (Ramsay Jones's message of "Wed, 8 Jun 2016 15:48:02 +0100")
Ramsay Jones <ramsay@ramsayjones•plus.com> writes:
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones•plus.com>
> ---
>
> Hi Michael, Junio,
>
> I would normally ask you to squash this into the relevant patch when
> you next re-roll your 'mh/ref-iterators' branch, but this has already
> been merged into next. (I normally have a bit more time ... sorry!).
>
> Perhaps, after the release, when the next branch is re-wound/re-built,
> this could be squashed into your branch then.
Yup, sounds like a plan.
>
> Anyway, after applying this patch, the following symbols are still
> 'public but unused':
>
> > refs/files-backend.o - files_reflog_iterator_begin
> > refs/iterator.o - is_empty_ref_iterator
> > refs/iterator.o - merge_ref_iterator_begin
>
> These all look (potentially) useful for the implementation of
> additional 'ref-iter' types and look to be part of the _internal_
> iterator API - so they should not be marked static. Can you just
> confirm my interpretation.
I am not Michael, but FWIW I think that is sensible.
next prev parent reply other threads:[~2016-06-08 18:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 14:48 [PATCH] refs: mark the file-local vtable symbols as static Ramsay Jones
2016-06-08 18:55 ` Junio C Hamano [this message]
2016-06-09 12:40 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfusnldc4.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mhagger@alum$(echo .)mit.edu \
--cc=ramsay@ramsayjones$(echo .)plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox