From: Junio C Hamano <gitster@pobox•com>
To: Stefan Beller <sbeller@google•com>
Cc: "git\@vger.kernel.org" <git@vger•kernel.org>,
Jens Lehmann <Jens.Lehmann@web•de>,
Heiko Voigt <hvoigt@hvoigt•net>
Subject: Re: [RFC/PATCH 1/2] submodule: implement `module_list` as a builtin helper
Date: Mon, 03 Aug 2015 14:38:11 -0700 [thread overview]
Message-ID: <xmqqfv406ojg.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAGZ79kY=39j4H=62=VZRm4VOcqzgOAU6tDpJVsqdeqnPtB8hQQ@mail.gmail.com> (Stefan Beller's message of "Mon, 3 Aug 2015 14:30:42 -0700")
Stefan Beller <sbeller@google•com> writes:
>> $ git submodule--helper module_list
>
> Why would you use an underscore in here as opposed to a dash?
Simply because the diff would be easier to read; the callers used to
call module_list shell function, now they call the subcommand with the
same name of submodule--helper.
next prev parent reply other threads:[~2015-08-03 21:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 0:19 [PATCH] add: remove dead code Stefan Beller
2015-07-31 16:41 ` Junio C Hamano
2015-07-31 23:09 ` [RFC/PATCH 0/2] Submodules: refactoring the `module_list` function Stefan Beller
2015-07-31 23:09 ` [RFC/PATCH 1/2] submodule: implement `module_list` as a builtin helper Stefan Beller
2015-08-01 1:01 ` Junio C Hamano
2015-08-03 21:30 ` Stefan Beller
2015-08-03 21:38 ` Junio C Hamano [this message]
2015-08-03 21:58 ` [PATCH] " Stefan Beller
2015-08-03 22:04 ` [RFC/PATCH 1/2] " Junio C Hamano
2015-08-03 22:13 ` Stefan Beller
2015-08-03 22:58 ` [PATCH] " Stefan Beller
2015-07-31 23:09 ` [RFC/PATCH 2/2] Testing the new code Stefan Beller
2015-08-01 1:02 ` Junio C Hamano
2015-08-03 16:23 ` Stefan Beller
2015-08-03 19:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfv406ojg.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Jens.Lehmann@web$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=hvoigt@hvoigt$(echo .)net \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox