Subject: Re: [PATCH v4] clone: simplify string handling in guess_dir_name()

From: Junio C Hamano <[email-masked]>
Date: Thu, 09 Jul 2015 14:21:18 -0700

Sebastian Schuberth <[email-masked]> writes:

> -	if (is_bare) {
> -		struct strbuf result = STRBUF_INIT;
> -		strbuf_addf(&result, "%.*s.git", (int)(end - start), start);
> -		dir = strbuf_detach(&result, NULL);
> -	} else
> +	if (is_bare)
> +		dir = xstrfmt("%.*s.git", (int)len, start);
> +	else
>  		dir = xstrndup(start, end - start);

The last one needs to be adjusted with s/end - start/len/.  The
last-minute rewrite without testing shows; your first two patches
correctly used "len" ;-)

No need to resend.  Will locally tweak before queuing.

Thanks.