From: Junio C Hamano <gitster@pobox•com>
To: Eric Sunshine <sunshine@sunshineco•com>
Cc: Patryk Obara <patryk.obara@gmail•com>, Git List <git@vger•kernel.org>
Subject: Re: [PATCH 2/2] commit: fix ending newline for template files
Date: Sat, 30 May 2015 09:59:38 -0700 [thread overview]
Message-ID: <xmqqfv6eatmt.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPig+cTrW9f1TGvpr4KH+EcOsy=FWvGRj6ZQM6nsFyXc15c4qg@mail.gmail.com> (Eric Sunshine's message of "Fri, 29 May 2015 18:25:29 -0400")
Eric Sunshine <sunshine@sunshineco•com> writes:
> On Fri, May 29, 2015 at 4:17 PM, Junio C Hamano <gitster@pobox•com> wrote:
>> By default, we should run clean-up after the editor we spawned gives
>> us the edited result. Not adding one more LF after the template
>> when it already ends with LF would not hurt, but an extra blank
>> after the template material does not hurt, either, so I am honestly
>> indifferent.
>
> I had a similar reaction. The one salient bit I picked up was that
> Patryk finds it aesthetically offensive[1] when the template ends with
> a comment line, and that comment line does not flow directly into the
> comment lines provided by --status. That is:
>
> Template line 1
> # Template line 2
>
> # Please enter the commit message...
> # with '#' will be ignored...
>
> [1]: Quoting from the commit message of patch 1/2: "...which is very
> annoying when template ends with line starting with '#'"
As I said in the message you are responding to, I do not think it
would hurt if we stopped adding an LF after a template that already
ends with LF. I think I am OK with a patch that does so without
doing anything else, like changing when clean-up happens, etc.
next prev parent reply other threads:[~2015-05-30 16:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 6:15 [PATCH 0/2] commit -t appends newline after template file Patryk Obara
2015-05-26 6:15 ` [PATCH 1/2] t750*: make tests for commit messages more pedantic Patryk Obara
2015-05-28 13:34 ` Eric Sunshine
2015-05-28 18:55 ` Junio C Hamano
2015-05-26 6:15 ` [PATCH 2/2] commit: fix ending newline for template files Patryk Obara
2015-05-28 14:29 ` Eric Sunshine
2015-05-28 18:22 ` Junio C Hamano
2015-05-28 18:35 ` Eric Sunshine
2015-05-29 20:17 ` Junio C Hamano
2015-05-29 22:25 ` Eric Sunshine
2015-05-30 11:29 ` Patryk Obara
2015-05-31 2:21 ` Eric Sunshine
2015-05-30 16:59 ` Junio C Hamano [this message]
2015-05-28 10:06 ` [PATCH 0/2] commit -t appends newline after template file Patryk Obara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfv6eatmt.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=patryk.obara@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox