From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Michael Haggerty <mhagger@alum•mit.edu>,
git discussion list <git@vger•kernel.org>
Subject: Re: [PATCH 2/2] log: do not shorten decoration names too early
Date: Thu, 14 May 2015 14:49:10 -0700 [thread overview]
Message-ID: <xmqqfv6yj0dl.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqq8ucr83h8.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Thu, 14 May 2015 10:37:39 -0700")
Junio C Hamano <gitster@pobox•com> writes:
> For example, we have this in commit.c:
>
> const void *get_cached_commit_buffer(const struct commit *commit, unsigned long *sizep)
> {
> struct commit_buffer *v = buffer_slab_at(&buffer_slab, commit);
> if (sizep)
> *sizep = v->size;
> return v->buffer;
> }
>
> But if we do not have the "buffer" data cached for that commit (via
> an earlier call to set_commit_buffer()), we don't have to enlarge
> the slab, as we are not adding anything to the slab system with this
> call.
The change may look something like this. I do not think it would
make a difference to the get_cached_commit_buffer() codepath (when
we use the commit->buffer, we pretty much know we use that for all
commits), though.
commit-slab.h | 27 ++++++++++++++++++++++++---
commit.c | 7 ++++++-
2 files changed, 30 insertions(+), 4 deletions(-)
diff --git a/commit-slab.h b/commit-slab.h
index 375c9c7..3334ab2 100644
--- a/commit-slab.h
+++ b/commit-slab.h
@@ -15,7 +15,13 @@
* - int *indegree_at(struct indegree *, struct commit *);
*
* This function locates the data associated with the given commit in
- * the indegree slab, and returns the pointer to it.
+ * the indegree slab, and returns the pointer to it. The location to
+ * store the data is allocated as necessary.
+ *
+ * - int *indegree_peek(struct indegree *, struct commit *);
+ *
+ * This function is similar to indegree_at(), but it will return NULL
+ * until a call to indegree_at() was made for the commit.
*
* - void init_indegree(struct indegree *);
* void init_indegree_with_stride(struct indegree *, int);
@@ -80,8 +86,9 @@ static MAYBE_UNUSED void clear_ ##slabname(struct slabname *s) \
s->slab = NULL; \
} \
\
-static MAYBE_UNUSED elemtype *slabname## _at(struct slabname *s, \
- const struct commit *c) \
+static MAYBE_UNUSED elemtype *slabname## _at_peek(struct slabname *s, \
+ const struct commit *c, \
+ int add_if_missing) \
{ \
int nth_slab, nth_slot; \
\
@@ -90,6 +97,8 @@ static MAYBE_UNUSED elemtype *slabname## _at(struct slabname *s, \
\
if (s->slab_count <= nth_slab) { \
int i; \
+ if (!add_if_missing) \
+ return NULL; \
s->slab = xrealloc(s->slab, \
(nth_slab + 1) * sizeof(*s->slab)); \
stat_ ##slabname## realloc++; \
@@ -103,6 +112,18 @@ static MAYBE_UNUSED elemtype *slabname## _at(struct slabname *s, \
return &s->slab[nth_slab][nth_slot * s->stride]; \
} \
\
+static MAYBE_UNUSED elemtype *slabname## _at(struct slabname *s, \
+ const struct commit *c) \
+{ \
+ return slabname##_at_peek(s, c, 1); \
+} \
+ \
+static MAYBE_UNUSED elemtype *slabname## _peek(struct slabname *s, \
+ const struct commit *c) \
+{ \
+ return slabname##_at_peek(s, c, 0); \
+} \
+ \
static int stat_ ##slabname## realloc
/*
diff --git a/commit.c b/commit.c
index 65179f9..2d1901f 100644
--- a/commit.c
+++ b/commit.c
@@ -244,7 +244,12 @@ void set_commit_buffer(struct commit *commit, void *buffer, unsigned long size)
const void *get_cached_commit_buffer(const struct commit *commit, unsigned long *sizep)
{
- struct commit_buffer *v = buffer_slab_at(&buffer_slab, commit);
+ struct commit_buffer *v = buffer_slab_peek(&buffer_slab, commit);
+ if (!v) {
+ if (sizep)
+ *sizep = 0;
+ return NULL;
+ }
if (sizep)
*sizep = v->size;
return v->buffer;
next prev parent reply other threads:[~2015-05-14 21:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 13:11 "HEAD -> branch" decoration doesn't work with "--decorate=full" Michael Haggerty
2015-05-13 14:51 ` Junio C Hamano
2015-05-13 15:26 ` Michael J Gruber
2015-05-13 17:11 ` Junio C Hamano
2015-05-13 17:13 ` Junio C Hamano
2015-05-13 19:40 ` [PATCH 2/2] log: do not shorten decoration names too early Junio C Hamano
2015-05-14 6:33 ` Jeff King
2015-05-14 17:37 ` Junio C Hamano
2015-05-14 17:49 ` Jeff King
2015-05-14 18:01 ` Junio C Hamano
2015-05-14 18:10 ` Jeff King
2015-05-14 21:49 ` Junio C Hamano [this message]
2015-05-14 21:54 ` Jeff King
2015-05-14 22:25 ` Junio C Hamano
2015-05-14 22:33 ` Jeff King
2015-05-22 21:21 ` Junio C Hamano
2015-05-22 21:38 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfv6yj0dl.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mhagger@alum$(echo .)mit.edu \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox