From: Junio C Hamano <gitster@pobox•com>
To: David Turner <dturner@twopensource•com>
Cc: git mailing list <git@vger•kernel.org>
Subject: Re: Freeing struct lock_file?
Date: Fri, 03 Apr 2015 15:01:46 -0700 [thread overview]
Message-ID: <xmqqfv8gg9bp.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1428097515.31333.2.camel@ubuntu> (David Turner's message of "Fri, 03 Apr 2015 17:45:15 -0400")
David Turner <dturner@twopensource•com> writes:
> Why is it impossible to free struct lock_files? I understand that they
> become part of a linked list, and that there's an atexit handler that
> goes over that list. But couldn't we just remove them from the linked
> list and then free them?
I suspect that the code is worried about getting a signal, while it
is manipulating the linked list, and then cause the atexit handler
to walk a list that is in a broken state.
next prev parent reply other threads:[~2015-04-03 22:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 21:45 Freeing struct lock_file? David Turner
2015-04-03 22:01 ` Junio C Hamano [this message]
2015-04-04 0:24 ` David Turner
2015-04-04 7:16 ` Torsten Bögershausen
2015-04-06 18:02 ` David Turner
2015-04-04 19:04 ` C99 (Was: Re: Freeing struct lock_file?) brian m. carlson
2015-04-04 20:06 ` C99 Junio C Hamano
2015-04-04 20:36 ` C99 brian m. carlson
2015-04-07 1:12 ` Freeing struct lock_file? David Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfv8gg9bp.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=dturner@twopensource$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox