From: Junio C Hamano <gitster@pobox•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: Stefan Beller <sbeller@google•com>,
"git\@vger.kernel.org" <git@vger•kernel.org>
Subject: Re: What's cooking in git.git (Dec 2014, #05; Mon, 29)
Date: Tue, 06 Jan 2015 16:29:37 -0800 [thread overview]
Message-ID: <xmqqfvbnmo0e.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150105200644.GJ29365@google.com> (Jonathan Nieder's message of "Mon, 5 Jan 2015 12:06:44 -0800")
Jonathan Nieder <jrnieder@gmail•com> writes:
> Stefan Beller wrote:
>> On Mon, Dec 29, 2014 at 1:28 PM, Junio C Hamano <gitster@pobox•com> wrote:
>
>>> * sb/copy-fd-errno (2014-11-17) 1 commit
>>> - copy.c: make copy_fd preserve meaningful errno
>>>
>>> Will be rerolled as a part of a larger series.
>>
>> I am not expecting to reroll this as part of a larger series any more.
>> So if this makes sense on its own, please pick it up?
>
> I think the errno-based approach is problematic. No callers today run
> into the problem the patch fixes and if a caller did, I fear that
> caller would be broken in other ways.
>
> That said, no one seemed too excited about the alternative that
> propagates the error message more explicitly with a strbuf. I'd be
> happy to re-send anyway, or I can work around this patch when
> rerolling.
OK, let's resurrect the issue when more people are actively
interested in having the right mechanism to propagate errors up in
the callchain. I just re-checked the callers of copy_fd and I agree
that this will not affect existing callers (including the one in
hold_lock_file_for_append() called by add_to_alternates_file() that
passes LOCK_DIE_ON_ERROR), so I am inclined to drop the patch for
now.
prev parent reply other threads:[~2015-01-07 0:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-29 21:28 What's cooking in git.git (Dec 2014, #05; Mon, 29) Junio C Hamano
2014-12-29 23:37 ` Philip Oakley
2014-12-30 15:55 ` Junio C Hamano
2015-01-02 0:18 ` Philip Oakley
2015-01-05 19:50 ` Stefan Beller
2015-01-05 20:06 ` Jonathan Nieder
2015-01-07 0:29 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfvbnmo0e.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox