From: Junio C Hamano <gitster@pobox•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: Jeff King <peff@peff•net>, Stefan Beller <sbeller@google•com>,
sahlberg@google•com, git@vger•kernel.org
Subject: Re: [PATCH 3/4] lock_ref_sha1_basic: simplify error code path
Date: Wed, 19 Nov 2014 13:41:18 -0800 [thread overview]
Message-ID: <xmqqfvderhq9.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20141119020713.GT6527@google.com> (Jonathan Nieder's message of "Tue, 18 Nov 2014 18:07:13 -0800")
Jonathan Nieder <jrnieder@gmail•com> writes:
> Jeff King wrote:
>
>> Hmph. Should we just abandon my series in favor of taking Ronnie's
>> original patch, then? We can apply the "save/restore errno in error()"
>> patch independently if we like.
>
> I liked patches 1 and 2 and the explanation from patch 4. Perhaps
> patch 3 should be replaced with a patch renaming unlock_ref to
> free_ref_lock or something.
Concurred.
next prev parent reply other threads:[~2014-11-19 21:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 23:17 [PATCH] refs.c: handle locking failure during transaction better Stefan Beller
2014-11-18 23:34 ` Stefan Beller
2014-11-19 1:13 ` Stefan Beller
2014-11-19 1:35 ` [PATCH 0/4] error cleanups in lock_ref_sha1_basic Jeff King
2014-11-19 1:37 ` [PATCH 1/4] error: save and restore errno Jeff King
2014-11-19 1:41 ` Stefan Beller
2014-11-19 1:43 ` Jonathan Nieder
2014-11-19 1:47 ` Jeff King
2014-11-19 18:14 ` Junio C Hamano
2014-11-19 18:28 ` Jeff King
2014-11-19 1:37 ` [PATCH 2/4] lock_ref_sha1_basic: simplify errno handling Jeff King
2014-11-19 1:54 ` Jonathan Nieder
2014-11-21 9:25 ` Michael Haggerty
2014-11-19 1:37 ` [PATCH 3/4] lock_ref_sha1_basic: simplify error code path Jeff King
2014-11-19 2:00 ` Jonathan Nieder
2014-11-19 2:04 ` Jeff King
2014-11-19 2:07 ` Jonathan Nieder
2014-11-19 21:41 ` Junio C Hamano [this message]
2014-11-19 22:28 ` Jeff King
2014-11-19 22:34 ` Junio C Hamano
2014-11-19 22:36 ` Jeff King
2014-11-20 1:07 ` Jonathan Nieder
2014-11-19 1:41 ` [PATCH 4/4] lock_ref_sha1_basic: do not die on locking errors Jeff King
2014-11-19 2:05 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfvderhq9.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=sahlberg@google$(echo .)com \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox