From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Jeremiah Mahler <jmmahler@gmail•com>, git@vger•kernel.org
Subject: Re: [PATCH v6] format-patch --signature-file <file>
Date: Wed, 21 May 2014 15:15:55 -0700 [thread overview]
Message-ID: <xmqqfvk2ok10.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140521220250.GA11970@sigill.intra.peff.net> (Jeff King's message of "Wed, 21 May 2014 18:02:50 -0400")
Jeff King <peff@peff•net> writes:
> I think he is responding to my earlier request to use test_must_fail
> instead of "!". But there is a subtlety there he does not know, which
> is that we typically only use the former for git programs, and rely on
> "!" for normal Unix commands.
Ok, that explains it. Thanks.
> Yeah, I noticed and gave a pass on this in earlier review, because the
> file is used across many tests. So burying it in the first test that
> uses it is probably a bad thing. However, it could go in its own setup
> test.
Yeah, placing it in its own setup may be the best. There are quite
a many set-ups outside the tests in this script from the olden days,
so I am OK if left it as-is and have a separate clean-up patch after
this topic settles. I am also OK to add a new one "the new right way"
so that a later clean-up patch does not have to change what is added
in this step.
next prev parent reply other threads:[~2014-05-21 22:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 1:02 [PATCH v6] format-patch --signature-file <file> Jeremiah Mahler
2014-05-21 1:02 ` Jeremiah Mahler
2014-05-21 21:13 ` Junio C Hamano
2014-05-21 21:24 ` Junio C Hamano
2014-05-21 21:32 ` Jeremiah Mahler
2014-05-21 21:50 ` Jeremiah Mahler
2014-05-21 21:58 ` Junio C Hamano
2014-05-21 22:02 ` Jeff King
2014-05-21 22:15 ` Junio C Hamano [this message]
2014-05-21 22:27 ` Jeremiah Mahler
2014-05-21 22:48 ` Junio C Hamano
2014-05-21 22:12 ` Jeremiah Mahler
2014-05-21 22:37 ` Junio C Hamano
2014-05-21 23:18 ` Jeremiah Mahler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfvk2ok10.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jmmahler@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox