From: Junio C Hamano <gitster@pobox•com>
To: Richard Hansen <rhansen@bbn•com>
Cc: git@vger•kernel.org, felipe.contreras@gmail•com
Subject: Re: [PATCH v2 2/9] test-lib.sh: convert $TEST_DIRECTORY to an absolute path
Date: Tue, 12 Nov 2013 12:06:14 -0800 [thread overview]
Message-ID: <xmqqfvr1gzbc.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <5281C522.7050403@bbn.com> (Richard Hansen's message of "Tue, 12 Nov 2013 01:05:22 -0500")
Richard Hansen <rhansen@bbn•com> writes:
> On 2013-11-12 00:54, Richard Hansen wrote:
>> If $TEST_DIRECTORY is specified in the environment, convert the value
>> to an absolute path to ensure that it remains valid even when 'cd' is
>> used.
>>
>> Signed-off-by: Richard Hansen <rhansen@bbn•com>
>
> Actually, credit for this and the next patch should go to Felipe. How
> should I note that?
If the patch text was copied from his response message, you would start
the _body_ of your e-mail as:
From: F.. C.. <felipe.contreras@gmail•com>
If $TEST_DIRECTORY is specified ...
Signed-off-by: F.. C.. <felipe.contreras@gmail•com>
Signed-off-by: R Hansen <rhansen@...>
_after_ getting him say it is OK to add his Sign-off. The first
line in the body of your e-mail, "From: Real Author", followed by a
blank line, will signal to "git am" that you are forwarding a patch
by somebody else, and we record that real author on the "author"
line of the resulting commit object.
On the other hand, if the patch is based on the _idea_ you gained by
discussing with him, you would just mention it near your sign-off,
like this:
If $TEST_DIRECTORY is specified ...
Helped-by: F... C... <felipe.contreras@gmail•com>
Signed-off-by: R... Hansen <rhansen@...>
>
> Thanks,
> Richard
>
>
>> ---
>> t/test-lib.sh | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/t/test-lib.sh b/t/test-lib.sh
>> index b25249e..af172d9 100644
>> --- a/t/test-lib.sh
>> +++ b/t/test-lib.sh
>> @@ -26,6 +26,10 @@ then
>> # outside of t/, e.g. for running tests on the test library
>> # itself.
>> TEST_DIRECTORY=$(pwd)
>> +else
>> + # ensure that TEST_DIRECTORY is an absolute path so that it
>> + # works even if the current working directory is changed
>> + TEST_DIRECTORY=$(cd "$TEST_DIRECTORY" && pwd) || exit 1
>> fi
>> if test -z "$TEST_OUTPUT_DIRECTORY"
>> then
next prev parent reply other threads:[~2013-11-12 20:06 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 4:05 [PATCH 0/7] remote-hg, remote-bzr fixes Richard Hansen
2013-11-11 4:05 ` [PATCH 1/7] remote-hg: don't decode UTF-8 paths into Unicode objects Richard Hansen
2013-11-11 11:04 ` Felipe Contreras
2013-11-11 18:30 ` Richard Hansen
2013-11-11 19:10 ` Felipe Contreras
2013-11-11 4:05 ` [PATCH 2/7] test-bzr.sh, test-hg.sh: allow running from any dir Richard Hansen
2013-11-11 11:35 ` Felipe Contreras
2013-11-11 18:31 ` Junio C Hamano
2013-11-11 18:58 ` Felipe Contreras
2013-11-11 4:05 ` [PATCH 3/7] test-bzr.sh, test-hg.sh: prepare for change to push.default=simple Richard Hansen
2013-11-11 11:37 ` Felipe Contreras
2013-11-11 19:20 ` Richard Hansen
2013-11-11 19:31 ` Felipe Contreras
2013-11-11 21:16 ` Richard Hansen
2013-11-11 21:19 ` Felipe Contreras
2013-11-11 4:05 ` [PATCH 4/7] test-hg.sh: eliminate 'local' bashism Richard Hansen
2013-11-11 11:40 ` Felipe Contreras
2013-11-11 4:05 ` [PATCH 5/7] test-hg.sh: avoid obsolete 'test' syntax Richard Hansen
2013-11-11 11:44 ` Felipe Contreras
2013-11-12 5:34 ` Richard Hansen
2013-11-12 20:23 ` Felipe Contreras
2013-11-11 4:05 ` [PATCH 6/7] test-hg.sh: help user correlate verbose output with email test Richard Hansen
2013-11-11 11:42 ` Felipe Contreras
2013-11-11 19:19 ` Richard Hansen
2013-11-11 19:29 ` Felipe Contreras
2013-11-11 21:17 ` Richard Hansen
2013-11-11 4:05 ` [PATCH 7/7] remote-bzr, remote-hg: fix email address regular expression Richard Hansen
2013-11-11 11:43 ` Felipe Contreras
2013-11-11 18:35 ` [PATCH 0/7] remote-hg, remote-bzr fixes Junio C Hamano
2013-11-12 5:54 ` [PATCH v2 0/9] " Richard Hansen
2013-11-12 5:54 ` [PATCH v2 1/9] remote-hg: don't decode UTF-8 paths into Unicode objects Richard Hansen
2013-11-12 5:54 ` [PATCH v2 2/9] test-lib.sh: convert $TEST_DIRECTORY to an absolute path Richard Hansen
2013-11-12 6:05 ` Richard Hansen
2013-11-12 20:06 ` Junio C Hamano [this message]
2013-11-12 20:25 ` Felipe Contreras
2013-11-12 5:54 ` [PATCH v2 3/9] test-bzr.sh, test-hg.sh: allow running from any dir Richard Hansen
2013-11-12 5:54 ` [PATCH v2 4/9] test-bzr.sh, test-hg.sh: prepare for change to push.default=simple Richard Hansen
2013-11-12 5:54 ` [PATCH v2 5/9] test-hg.sh: eliminate 'local' bashism Richard Hansen
2013-11-12 5:54 ` [PATCH v2 6/9] test-hg.sh: avoid obsolete 'test' syntax Richard Hansen
2013-11-12 5:54 ` [PATCH v2 7/9] test-hg.sh: fix duplicate content strings in author tests Richard Hansen
2013-11-12 5:54 ` [PATCH v2 8/9] test-hg.sh: help user correlate verbose output with email test Richard Hansen
2013-11-12 5:54 ` [PATCH v2 9/9] remote-bzr, remote-hg: fix email address regular expression Richard Hansen
2013-11-12 17:59 ` [PATCH v2 0/9] remote-hg, remote-bzr fixes Junio C Hamano
2013-11-12 20:27 ` Felipe Contreras
2013-11-18 4:12 ` [PATCH v3 " Richard Hansen
2013-11-18 4:12 ` [PATCH v3 1/9] remote-hg: don't decode UTF-8 paths into Unicode objects Richard Hansen
2013-11-18 4:12 ` [PATCH v3 2/9] test-lib.sh: convert $TEST_DIRECTORY to an absolute path Richard Hansen
2013-11-18 4:12 ` [PATCH v3 3/9] test-bzr.sh, test-hg.sh: allow running from any dir Richard Hansen
2013-11-18 4:12 ` [PATCH v3 4/9] test-bzr.sh, test-hg.sh: prepare for change to push.default=simple Richard Hansen
2013-11-18 4:12 ` [PATCH v3 5/9] test-hg.sh: eliminate 'local' bashism Richard Hansen
2013-11-18 4:12 ` [PATCH v3 6/9] test-hg.sh: avoid obsolete 'test' syntax Richard Hansen
2013-11-18 4:12 ` [PATCH v3 7/9] test-hg.sh: fix duplicate content strings in author tests Richard Hansen
2013-11-18 4:12 ` [PATCH v3 8/9] test-hg.sh: help user correlate verbose output with email test Richard Hansen
2013-11-18 4:12 ` [PATCH v3 9/9] remote-bzr, remote-hg: fix email address regular expression Richard Hansen
2013-11-18 16:13 ` [PATCH v3 0/9] remote-hg, remote-bzr fixes Junio C Hamano
2013-11-18 21:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfvr1gzbc.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=felipe.contreras@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=rhansen@bbn$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox