Subject: Re: [PATCH v16 07/10] imap-send: add ability to list the available folders

From: Junio C Hamano <[email-masked]>
Date: Mon, 09 Jun 2025 11:42:30 -0700

Aditya Garg <[email-masked]> writes:

> diff --git a/imap-send.c b/imap-send.c
> index a4cccb9110..f03a92a2fb 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -45,15 +45,21 @@
>  #endif
>  
>  static int verbosity;
> +static int list_folders = 0;

Let's lose " = 0" here.

Do not explicitly initialize globals to 0 or NULL; let BSS take care
of the zero initialization, instead.

> -static const char * const imap_send_usage[] = { "git imap-send [-v] [-q] [--[no-]curl] [(--folder|-f) <folder>] < <mbox>", NULL };
> +static char const * const imap_send_usage[] = {
> +	N_("git imap-send [-v] [-q] [--[no-]curl] [(--folder|-f) <folder>] < <mbox>"),
> +	"git imap-send --list",
> +	NULL
> +};

Good.