Subject: Re: [PATCH] config.mak.dev: enable -Wunreachable-code

From: Junio C Hamano <[email-masked]>
Date: Tue, 03 Jun 2025 15:07:36 -0700

Mike Hommey <[email-masked]> writes:

> There is a similar problem with this code in refs/files-backend.c:
>
> 			if (!create_ref_symlink(lock, update->new_target))
> 				continue;
>
> Where create_ref_symlink is defined as such:
>
> #ifdef NO_SYMLINK_HEAD
> #define create_ref_symlink(a, b) (-1)
> #else
> static int create_ref_symlink(struct ref_lock *lock, const char *target)
> {
> ...
> #endif
>
> And NO_SYMLINK_HEAD is defined on Windows.

Would the NOT_CONSTANT() trick we ended up using for the original
"sigfillset" thing solve your issue as well?