Subject: Re: [PATCH v3 2/3] git-compat-util: add NOT_CONSTANT macro and use it in atfork_prepare()

From: Junio C Hamano <[email-masked]>
Date: Tue, 18 Mar 2025 16:55:08 -0700

Calvin Wan <[email-masked]> writes:

> On Tue, Mar 18, 2025 at 3:05 PM Calvin Wan <[email-masked]> wrote:
>>
>> Junio C Hamano <[email-masked]> writes:
>> > Our hope is that the number of code paths that falsely trigger
>> > @@ -985,6 +985,7 @@ LIB_OBJS += compat/nonblock.o
>> >  LIB_OBJS += compat/obstack.o
>> >  LIB_OBJS += compat/terminal.o
>> >  LIB_OBJS += compat/zlib-uncompress2.o
>> > +LIB_OBJS += compiler-tricks/not-a-constant.o
>>
>> The name is correctly added here, but in `next,` this name is set to
>> `compiler-tricks/not-constant.o`.
>
> Apologies you can ignore this -- we needed to add a reference to the new folder
> internally so this was a red herring for our broken build.

Sorry, I may not have sent a reroll to the list for the version that
went into 'next'.  It should have lost "a" from not-constant
consistently everywhere.

Thanks for being eagle-eyed.