Subject: Re: [PATCH 2/2] tr2: shows scope unconditionally in addition to key-value pair

From: Junio C Hamano <[email-masked]>
Date: Thu, 21 Jul 2022 09:57:10 -0700

"tenglong.tl" <[email-masked]> writes:

> diff --git a/Documentation/technical/api-trace2.txt b/Documentation/technical/api-trace2.txt
> index dcd0429037..229f31ab31 100644
> --- a/Documentation/technical/api-trace2.txt
> +++ b/Documentation/technical/api-trace2.txt
> @@ -717,6 +717,7 @@ The "exec_id" field is a command-unique id and is only useful if the
>  {
>  	"event":"def_param",
>  	...
> +	scope: <a string that 'git config --show-scope' would return>
>  	"param":"core.abbrev",
>  	"value":"7"
>  }

Everything in these examples use concrete values and follow the real
syntax (e.g. param is enclosed in double-quotes and so is its value
core.abbrev; even though core.abbrev is not the only param that can
be reported by a def-param event, it is used as a concrete example.
The same story goes for value).  The new "scope" thing stands out
like a sore thumb.  I think the above should read more like

	"event":"def_param",
	...
	"scope":"global",
	"param":"core.abbrev",
	"value":"7"

or something.  Pick your favourite value for scope.

Other than that, these two patches make quite a lot of sense.

Thanks.