Subject: Re: [RFC PATCH 03/15] reftable: don't memset() a NULL from failed malloc()

From: Junio C Hamano <[email-masked]>
Date: Mon, 06 Jun 2022 10:44:17 -0700

Ævar Arnfjörð Bjarmason <[email-masked]> writes:

> Yes, but I think in this case most of these are either 100% legitimate
> issues, or things where we'd like to e.g. add a BUG() assertion anyway,
> e.g. in the diff parsing case.

Where does that "BUG() assertion anyway" comes from?  What are we
protecting against?

I do not think such a BUG() added only for placating -fanalyzer
falls into "legitimate" category at all.