From: Junio C Hamano <gitster@pobox•com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
Cc: Fabian Stelzer <fs@gigacodes•de>,
git@vger•kernel.org, Adam Dinwoodie <adam@dinwoodie•org>,
Jeff King <peff@peff•net>
Subject: Re: [PATCH v3 3/3] test-lib: make BAIL_OUT() work in tests and prereq
Date: Mon, 22 Nov 2021 09:05:06 -0800 [thread overview]
Message-ID: <xmqqh7c4i0jh.fsf@gitster.g> (raw)
In-Reply-To: <211122.86y25gz9q7.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Mon, 22 Nov 2021 12:52:42 +0100")
Ævar Arnfjörð Bjarmason <avarab@gmail•com> writes:
>> -exec 5>&1
>> -exec 6<&0
>> -exec 7>&2
>
> This doesn't break (I think) with your change here because you only
> manipulate >&5, but I think the post-image would be lot clearer if...
>
>> if test "$verbose_log" = "t"
>> then
>> exec 3>>"$GIT_TEST_TEE_OUTPUT_FILE" 4>&3
>
> ...this bit of code were moved up along with the "exec". They're
> currently intentionally snuggled together as we conditionally set the
> 3rd and 4th fd depending on verbose/tee settings right after the setup
> of 5/6/7, keeping them grouped in the post-image makes more sense than
> splitting them up here.
I actually have to wonder if the handling of 3 and 4 should be moved
down, not up like you suggest, so that they are grouped together
with the maybe_teardown_verbose and the maybe_setup_verbose helper
functions. The lines we see here are the file descriptors that are
always redirected, which is a bit different. Raising all of them up
to group them together is also fine.
In any case, the comment in front of the block of exec wants to
become a bit more detailed than just "# Set up additional fds", with
an explanation about which FD is used for what.
And any change that involves handling of FD #4 probably wants to
further include the BASH_XTRACEFD setting.
Thanks.
next prev parent reply other threads:[~2021-11-22 17:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 9:04 [PATCH v2 0/2] test-lib: improve missing prereq handling Fabian Stelzer
2021-11-17 9:04 ` [PATCH v2 1/2] test-lib: show missing prereq summary Fabian Stelzer
2021-11-17 9:04 ` [PATCH v2 2/2] test-lib: introduce required prereq for test runs Fabian Stelzer
2021-11-18 23:42 ` Junio C Hamano
2021-11-19 9:07 ` Fabian Stelzer
2021-11-19 11:13 ` Ævar Arnfjörð Bjarmason
2021-11-19 13:48 ` Fabian Stelzer
2021-11-19 14:09 ` Fabian Stelzer
2021-11-19 14:26 ` Ævar Arnfjörð Bjarmason
2021-11-19 15:40 ` Fabian Stelzer
2021-11-19 16:37 ` Ævar Arnfjörð Bjarmason
2021-11-20 15:03 ` [PATCH v3 0/3] test-lib: improve missing prereq handling Fabian Stelzer
2021-11-20 15:03 ` [PATCH v3 1/3] test-lib: show missing prereq summary Fabian Stelzer
2021-11-20 15:04 ` [PATCH v3 2/3] test-lib: introduce required prereq for test runs Fabian Stelzer
2021-11-20 15:04 ` [PATCH v3 3/3] test-lib: make BAIL_OUT() work in tests and prereq Fabian Stelzer
2021-11-22 11:52 ` Ævar Arnfjörð Bjarmason
2021-11-22 17:05 ` Junio C Hamano [this message]
2021-11-26 9:55 ` Fabian Stelzer
2021-11-26 21:02 ` Junio C Hamano
2021-11-27 12:47 ` Fabian Stelzer
2021-11-28 23:38 ` Junio C Hamano
2021-11-30 14:38 ` Fabian Stelzer
2021-11-30 14:59 ` Ævar Arnfjörð Bjarmason
2021-12-01 8:53 ` [PATCH v4 0/3] test-lib: improve missing prereq handling Fabian Stelzer
2021-12-01 8:53 ` [PATCH v4 1/3] test-lib: show missing prereq summary Fabian Stelzer
2021-12-01 8:53 ` [PATCH v4 2/3] test-lib: introduce required prereq for test runs Fabian Stelzer
2021-12-01 8:53 ` [PATCH v4 3/3] test-lib: make BAIL_OUT() work in tests and prereq Fabian Stelzer
2021-12-01 23:13 ` Junio C Hamano
2021-12-01 21:05 ` [PATCH v4 0/3] test-lib: improve missing prereq handling Adam Dinwoodie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh7c4i0jh.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=adam@dinwoodie$(echo .)org \
--cc=avarab@gmail$(echo .)com \
--cc=fs@gigacodes$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox