From: Junio C Hamano <gitster@pobox•com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] wildmatch test: cover a blind spot in "/" matching
Date: Sat, 10 Jun 2017 10:57:56 +0900 [thread overview]
Message-ID: <xmqqh8zo4na3.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqlgp04ne3.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Sat, 10 Jun 2017 10:55:32 +0900")
Junio C Hamano <gitster@pobox•com> writes:
> Ævar Arnfjörð Bjarmason <avarab@gmail•com> writes:
>
>> Add a test which covers a blindspot in how these tests should assert
>> that negated character classes are allowed or not allowed to match "/"
>> in certain circumstances.
>
> Please make this a bit more explicit, something like
>
> A negated character class that does not include '/',
> e.g. [^a-z],
oops. I think the class includes '/'; please excuse loose logic in
a "something like" meant as an illustration to show the level of
details expected ;-)
next prev parent reply other threads:[~2017-06-10 1:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-27 9:13 [PATCH] wildmatch test: cover a blind spot in "/" matching Ævar Arnfjörð Bjarmason
2017-06-09 16:21 ` Ævar Arnfjörð Bjarmason
2017-06-10 1:55 ` Junio C Hamano
2017-06-10 1:57 ` Junio C Hamano [this message]
2017-06-10 11:31 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh8zo4na3.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=avarab@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox