public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Ramsay Jones <ramsay@ramsayjones•plus.com>
Cc: Eric Wong <e@80x24•org>, Michael J Gruber <git@grubix•eu>,
	git@vger•kernel.org
Subject: Re: [PATCH] name-rev: use larger timestamp for is_better_name
Date: Sun, 21 May 2017 08:21:35 +0900	[thread overview]
Message-ID: <xmqqh90fru68.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <fe9ca677-1f38-4b61-a610-9f8ab014daff@ramsayjones.plus.com> (Ramsay Jones's message of "Sat, 20 May 2017 22:16:10 +0100")

Ramsay Jones <ramsay@ramsayjones•plus.com> writes:

> I test on 32-bit Linux from time to time, and tonight's 'pu'
> branch fails t4202.44, t6007.2,5-6,12-13,16, t6012.2-11,
> t6111.2-65. I bisected the t4202 failure to a merge commit
> (99d31e1378, merge branch 'jc/name-rev-lw-tag') and I spotted
> the 'unsigned long' taggerdate parameter to the is_better_name()
> function.

Thanks.  My earlier "oh, cutoff that was long also is a timestamp"
patch was what I did while making this exact "evil merge" change,
and then when I re-integrated everything, I forgot about it.

I'll teach my rerere database about this.  Thanks.

      reply	other threads:[~2017-05-20 23:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-20 20:36 [PATCH] name-rev: use larger timestamp for is_better_name Eric Wong
2017-05-20 21:16 ` Ramsay Jones
2017-05-20 23:21   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh90fru68.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=e@80x24$(echo .)org \
    --cc=git@grubix$(echo .)eu \
    --cc=git@vger$(echo .)kernel.org \
    --cc=ramsay@ramsayjones$(echo .)plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox