From: Junio C Hamano <gitster@pobox•com>
To: Stefan Beller <sbeller@google•com>
Cc: "git\@vger.kernel.org" <git@vger•kernel.org>
Subject: Re: What's cooking in git.git (Sep 2016, #08; Tue, 27)
Date: Mon, 03 Oct 2016 14:56:46 -0700 [thread overview]
Message-ID: <xmqqh98t5c69.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kYt+Z=ff1b2G+wWRAGGS=je+dpksfmMXj0fWwYVvHk8Cg@mail.gmail.com> (Stefan Beller's message of "Mon, 3 Oct 2016 14:49:51 -0700")
Stefan Beller <sbeller@google•com> writes:
> // Note: git_attr_check_elem seems to be useless now, as the
> // results are not stored in there, we only make use of the `attr` key.
I do not think git_attr_check_elem would be visible to the callers,
once we split the "inquiry" and "result" like the code illustrated
above. I actually doubt that the type would even internally need to
survive such a rewrite.
The point of "future-proofing" the callers is to hide such
implementation details from them. We know that the current API will
need to be updated at least once to prepare the implementation of
the API so that it has some chance of becoming thread-safe, and I
think we know enough how the updated API should look like to the
callers. I was hoping the minimum future-proofing would allow us to
update the current "attr" API users only once, without having to
update them again when we make it ready to be used in threaded
environment.
next prev parent reply other threads:[~2016-10-03 21:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 23:23 What's cooking in git.git (Sep 2016, #08; Tue, 27) Junio C Hamano
2016-10-01 1:33 ` Stefan Beller
2016-10-03 18:07 ` Junio C Hamano
2016-10-03 19:55 ` Stefan Beller
2016-10-03 20:17 ` Junio C Hamano
2016-10-03 20:49 ` Junio C Hamano
2016-10-03 21:49 ` Stefan Beller
2016-10-03 21:56 ` Junio C Hamano [this message]
2016-10-03 22:17 ` Stefan Beller
2016-10-04 16:11 ` Junio C Hamano
2016-10-04 22:36 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh98t5c69.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox