From: Junio C Hamano <gitster@pobox•com>
To: Eric Sunshine <sunshine@sunshineco•com>
Cc: Michael Haggerty <mhagger@alum•mit.edu>,
Git List <git@vger•kernel.org>, Duy Nguyen <pclouds@gmail•com>
Subject: Re: [PATCH v2 0/5] mh: worktree-related doc fixes
Date: Thu, 23 Jul 2015 17:51:51 -0700 [thread overview]
Message-ID: <xmqqh9ounzrs.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPig+cRLZiLSrMDiPp9ZJ1RKELSEKqVc0K2h4CvnvXNk5t7aBw@mail.gmail.com> (Eric Sunshine's message of "Thu, 23 Jul 2015 20:10:26 -0400")
Eric Sunshine <sunshine@sunshineco•com> writes:
> On Mon, Jul 20, 2015 at 11:31 AM, Michael Haggerty <mhagger@alum•mit.edu> wrote:
>> On 07/19/2015 10:29 PM, Eric Sunshine wrote:
>>> This re-roll of Michael Haggerty's worktree-related documentation
>>> tweaks[1] takes my review comments into account and adds one new patch.
>>
>> Thanks for separating the wheat from the chaff. I'm still traveling,
>> which I'll claim as an excuse for my poor responsiveness.
>>
>> All of your changes look good.
>>
>> I was wondering one thing: is there a value like "never" or "false" to
>> which "gc.worktreepruneexpire" can be set to turn off pruning entirely?
>> If so, it might be nice to mention it in the config manpage. Similarly
>> for the other expiration grace time settings.
>> But it's definitely not a blocker.
>
> I browsed the code for the various "expire" settings, and it appears
> that they all accept and respect "now" and "never", as well, so I'll
> put together a patch as suggested.
Sounds good; thanks.
prev parent reply other threads:[~2015-07-24 0:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 5:29 [PATCH v2 0/5] mh: worktree-related doc fixes Eric Sunshine
2015-07-20 5:29 ` [PATCH v2 1/5] Documentation/git-worktree: consistently use term "linked working tree" Eric Sunshine
2015-07-20 5:29 ` [PATCH v2 2/5] Documentation/git-worktree: fix incorrect reference to file "locked" Eric Sunshine
2015-07-20 5:29 ` [PATCH v2 3/5] Documentation/config: fix stale "git prune --worktree" reference Eric Sunshine
2015-07-20 5:29 ` [PATCH v2 4/5] Documentation/git-worktree: wordsmith worktree-related manpages Eric Sunshine
2015-07-20 5:29 ` [PATCH v2 5/5] config: rename "gc.pruneWorktreesExpire" to "gc.worktreePruneExpire" Eric Sunshine
2015-07-20 15:31 ` [PATCH v2 0/5] mh: worktree-related doc fixes Michael Haggerty
2015-07-24 0:10 ` Eric Sunshine
2015-07-24 0:51 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh9ounzrs.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mhagger@alum$(echo .)mit.edu \
--cc=pclouds@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox