From: Junio C Hamano <gitster@pobox•com>
To: Elia Pinto <gitter.spiros@gmail•com>
Cc: git@vger•kernel.org, jrnieder@gmail•com
Subject: Re: [PATCH 02/20] contrib/examples/git-clone.sh: avoid "test <cond> -a/-o <cond>"
Date: Mon, 09 Jun 2014 16:23:58 -0700 [thread overview]
Message-ID: <xmqqha3td5v5.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: 1402066563-28519-3-git-send-email-gitter.spiros@gmail.com
Elia Pinto <gitter.spiros@gmail•com> writes:
> The construct is error-prone; "test" being built-in in most modern
> shells, the reason to avoid "test <cond> && test <cond>" spawning
> one extra process by using a single "test <cond> -a <cond>" no
> longer exists.
>
> Signed-off-by: Elia Pinto <gitter.spiros@gmail•com>
> ---
> contrib/examples/git-clone.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/examples/git-clone.sh b/contrib/examples/git-clone.sh
> index b4c9376..08cf246 100755
> --- a/contrib/examples/git-clone.sh
> +++ b/contrib/examples/git-clone.sh
> @@ -516,7 +516,7 @@ then
>
> case "$no_checkout" in
> '')
> - test "z$quiet" = z -a "z$no_progress" = z && v=-v || v=
> + test "z$quiet" = z && test "z$no_progress" = z && v=-v || v=
> git read-tree -m -u $v HEAD HEAD
> esac
> fi
Hmph. If we want to see them both empty,
test "$quiet,$no_progress" = ,
would have been a better way to spell this, but that is outside the
scope of this series.
But I wonder if we really want to update the contrib/examples/,
which is a record of how historically we have implemented various
scripted Porcelains using lower level plumbing commands.
next prev parent reply other threads:[~2014-06-09 23:24 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 14:55 [PATCH 00/20] avoid "test <cond> -a/-o <cond>" Elia Pinto
2014-06-06 14:55 ` [PATCH 01/20] check_bindir: " Elia Pinto
2014-06-06 14:55 ` [PATCH 02/20] contrib/examples/git-clone.sh: " Elia Pinto
2014-06-09 23:23 ` Junio C Hamano [this message]
2014-06-06 14:55 ` [PATCH 03/20] contrib/examples/git-commit.sh: " Elia Pinto
2014-06-10 18:36 ` David Aguilar
2014-06-06 14:55 ` [PATCH 04/20] contrib/examples/git-merge.sh: " Elia Pinto
2014-06-06 14:55 ` [PATCH 05/20] contrib/examples/git-repack.sh: " Elia Pinto
2014-06-10 18:39 ` David Aguilar
2014-06-06 14:55 ` [PATCH 06/20] contrib/examples/git-resolve.sh: " Elia Pinto
2014-06-06 14:55 ` [PATCH 07/20] git-bisect.sh: " Elia Pinto
2014-06-06 14:55 ` [PATCH 08/20] git-mergetool.sh: " Elia Pinto
2014-06-10 7:37 ` David Aguilar
2014-06-06 14:55 ` [PATCH 09/20] git-rebase--interactive.sh: " Elia Pinto
2014-06-10 18:43 ` David Aguilar
2014-06-06 14:55 ` [PATCH 10/20] git-submodule.sh: " Elia Pinto
2014-06-09 23:23 ` Junio C Hamano
2014-06-10 6:52 ` Johannes Sixt
2014-06-10 8:19 ` Johannes Sixt
2014-06-06 14:55 ` [PATCH 11/20] t/lib-httpd.sh: " Elia Pinto
2014-06-06 14:55 ` [PATCH 12/20] t/t0025-crlf-auto.sh: " Elia Pinto
2014-06-06 14:55 ` [PATCH 13/20] t/t0026-eol-config.sh: " Elia Pinto
2014-06-06 14:55 ` [PATCH 14/20] t/t4102-apply-rename.sh: " Elia Pinto
2014-06-06 14:55 ` [PATCH 15/20] t/t5000-tar-tree.sh: " Elia Pinto
2014-06-10 18:49 ` David Aguilar
2014-06-10 19:21 ` David Aguilar
2014-06-10 20:08 ` David Aguilar
2014-06-10 21:47 ` René Scharfe
2014-06-06 14:55 ` [PATCH 16/20] t/t5403-post-checkout-hook.sh: " Elia Pinto
2014-06-06 14:56 ` [PATCH 17/20] t/t5538-push-shallow.sh: " Elia Pinto
2014-06-06 14:56 ` [PATCH 18/20] t/t9814-git-p4-rename.sh: " Elia Pinto
2014-06-06 14:56 ` [PATCH 19/20] t/test-lib-functions.sh: " Elia Pinto
2014-06-06 14:56 ` [PATCH 20/20] CodingGuidelines: " Elia Pinto
2014-06-06 19:04 ` Torsten Bögershausen
2014-06-09 13:31 ` [PATCH 00/20] " Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqha3td5v5.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitter.spiros@gmail$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox