public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <junio@pobox•com>
To: Christian Couder <chriscool@tuxfamily•org>
Cc: git@vger•kernel.org, Johan Herland <johan@herland•net>,
	Josh Triplett <josh@joshtriplett•org>,
	Thomas Rast <tr@thomasrast•ch>,
	Michael Haggerty <mhagger@alum•mit.edu>,
	Dan Carpenter <dan.carpenter@oracle•com>,
	Greg Kroah-Hartman <greg@kroah•com>, Jeff King <peff@peff•net>,
	Eric Sunshine <sunshine@sunshineco•com>,
	Ramsay Jones <ramsay@ramsay1•demon.co.uk>
Subject: Re: [PATCH v9 08/11] trailer: add tests for "git interpret-trailers"
Date: Tue, 01 Apr 2014 15:51:54 -0700	[thread overview]
Message-ID: <xmqqha6cy86t.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: Junio C. Hamano's message of "Tue\, 01 Apr 2014 14\:55\:21 -0700"

Junio C Hamano <gitster@pobox•com> writes:

> Christian Couder <chriscool@tuxfamily•org> writes:
>
>> +test_expect_success '--trim-empty without config' '
>> +	cat >expected <<-\EOF &&
>> +		ack: Peff
>> +		Acked-by: Johan
>> +	EOF
>> +	git interpret-trailers --trim-empty "ack = Peff" "Reviewed-by" "Acked-by: Johan" "sob:" >actual &&
>> +	test_cmp expected actual
>> +'
>
> Let's avoid these overlong and unreadable lines by doing something
> like this (just one hunk shown for illustration):
>
>  		ack: Peff
>  		Acked-by: Johan
>  	EOF
> -	git interpret-trailers --trim-empty "ack = Peff" "Reviewed-by" "Acked-by: Johan" "sob:" >actual &&
> +	git interpret-trailers --trim-empty "ack = Peff" \
> +		"Reviewed-by" "Acked-by: Johan" "sob:" >actual &&
>  	test_cmp expected actual
>  '
>  

I'll squash in the line-chopping fix to this, and also fill a
missing whitespace in 3/11 before pushing it out to 'pu'.  Hopefully
the result can be later merged to 'next' without further rerolls.

Thanks.

next prev parent reply	other threads:[~2014-04-03  9:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-01 19:20 [PATCH v9 00/11] Add interpret-trailers builtin Christian Couder
2014-04-01 19:20 ` [PATCH v9 01/11] trailer: add data structures and basic functions Christian Couder
2014-04-01 19:20 ` [PATCH v9 02/11] trailer: process trailers from stdin and arguments Christian Couder
2014-04-01 19:20 ` [PATCH v9 03/11] trailer: read and process config information Christian Couder
2014-04-01 19:20 ` [PATCH v9 04/11] trailer: process command line trailer arguments Christian Couder
2014-04-01 19:20 ` [PATCH v9 05/11] trailer: parse trailers from stdin Christian Couder
2014-04-01 19:20 ` [PATCH v9 06/11] trailer: put all the processing together and print Christian Couder
2014-04-01 19:20 ` [PATCH v9 07/11] trailer: add interpret-trailers command Christian Couder
2014-04-01 19:20 ` [PATCH v9 08/11] trailer: add tests for "git interpret-trailers" Christian Couder
2014-04-01 22:51   ` Junio C Hamano [this message]
2014-04-01 22:54   ` Junio C Hamano
2014-04-02  6:02     ` Christian Couder
2014-04-01 19:20 ` [PATCH v9 09/11] trailer: execute command from 'trailer.<name>.command' Christian Couder
2014-04-01 19:20 ` [PATCH v9 10/11] trailer: add tests for commands in config file Christian Couder
2014-04-01 19:20 ` [PATCH v9 11/11] Documentation: add documentation for 'git interpret-trailers' Christian Couder
2014-04-02  0:39   ` Jonathan Nieder
2014-04-02  6:01     ` Christian Couder
2014-04-04 22:33       ` Junio C Hamano
2014-04-04 22:42         ` Junio C Hamano
2014-04-07  9:39           ` Christian Couder
2014-04-07 16:52             ` Junio C Hamano
2014-04-07 18:58               ` Christian Couder
2014-04-07 19:34                 ` Junio C Hamano
2014-04-07 22:00                 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqha6cy86t.fsf@gitster.dls.corp.google.com \
    --to=junio@pobox$(echo .)com \
    --cc=chriscool@tuxfamily$(echo .)org \
    --cc=dan.carpenter@oracle$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=greg@kroah$(echo .)com \
    --cc=johan@herland$(echo .)net \
    --cc=josh@joshtriplett$(echo .)org \
    --cc=mhagger@alum$(echo .)mit.edu \
    --cc=peff@peff$(echo .)net \
    --cc=ramsay@ramsay1$(echo .)demon.co.uk \
    --cc=sunshine@sunshineco$(echo .)com \
    --cc=tr@thomasrast$(echo .)ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox